search

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.54k stars 9.32k forks source link

Mark moved interfaces as API #32038

Open sivaschenko opened 3 years ago

sivaschenko commented 3 years ago

The following interfaces should be moved and marked as API

Depends on https://github.com/magento/magento2/issues/32040 (moving and deprecation of interfaces in 2.4)

  1. app/code/Magento/AsynchronousOperations/Model/OperationRepositoryInterface.php: Move to \Magento\AsynchronousOperations\Model\ResourceModel\Operation\OperationRepository and then mark as @api in 2.5. Deprecate in 2.4
  2. lib/internal/Magento/Framework/View/Asset/PreProcessor/Helper/SortInterface.php: Move out from /Helper/ namespace and then mark as API in 2.5. Deprecate in 2.4
  3. app/code/Magento/Quote/Model/GuestCart/GuestShippingMethodManagementInterface.php: Interface with the same name exists in /Api/ scope, which is confusing. Need to refactor somehow to eliminate confusion and then mark as @api in 2.5. Deprecate in 2.4
  4. app/code/Magento/Quote/Model/ShippingMethodManagementInterface.php: Interface with the same name exists in /Api/ scope, which is confusing. Need to refactor somehow to eliminate confusion and then mark as @api in 2.5. Deprecate in 2.4
  5. app/code/Magento/MediaGalleryUi/Model/InsertImageDataInterface.php: This interface should be extracted to a separate module together with GetInsertImageData and GetInsertImageContent services and marked as APIa
m2-assistant[bot] commented 3 years ago

Hi @sivaschenko. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

AndreyChorniy commented 3 years ago

@magento I am working on this

AndreyChorniy commented 3 years ago

Hello @sivaschenko, I would like to clarify point 5 from your description

app/code/Magento/MediaGalleryUi/Model/InsertImageDataInterface.php: This interface should be extracted to a separate module together with GetInsertImageData and GetInsertImageContent services and marked as API

Questions:

  1. GetInsertImageData and GetInsertImageContent this is not interfaces and they should not be marked as API as well. Is this is the correct suggestion?
  2. Do we need to create a separate extension for only one interface app/code/Magento/MediaGalleryUi/Model/InsertImageDataInterface.php:? Is this is a good solution to create a folder API for extension MediaGalleryUi and move this interface to this folder.

Please advise.

Thank you.