magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.55k stars 9.32k forks source link

Remove deprecated interfaces #32064

Open sivaschenko opened 3 years ago

sivaschenko commented 3 years ago

Remove the following deprecated interfaces in 2.5-develop branch.

This task depends on deprecation in 2.4: https://github.com/magento/magento2/issues/32063

  1. app/code/Magento/Analytics/Model/ConfigInterface.php: should be replaced by Magento\Framework\Config\DataInterface
  2. app/code/Magento/Analytics/Model/Connector/Http/ClientInterface.php: should be replaced by Psr\Http\Client\ClientInterface
  3. app/code/Magento/Analytics/Model/Connector/Http/ResponseHandlerInterface.php: related to app/code/Magento/Analytics/Model/Connector/Http/ClientInterface.php
  4. app/code/Magento/Analytics/ReportXml/ConfigInterface.php: should be replaced by Magento\Framework\Config\DataInterface
  5. app/code/Magento/GraphQl/Model/Query/ContextFactoryInterface.php: Interfaces are not necessary for factories, should be deprecated and later removed
  6. app/code/Magento/Sales/Model/ResourceModel/HelperInterface.php: 1 usage, need to be eliminated in favor of private implementation
  7. lib/internal/Magento/Framework/Filter/Encrypt/AdapterInterface.php: No implementations, there are preference but they implement zend interface directly. Seems unused
  8. lib/internal/Magento/Framework/GraphQl/Query/PostFetchProcessorInterface.php: Not used
  9. lib/internal/Magento/Framework/Model/Operation/ReadInterface.php: Not used
  10. lib/internal/Magento/Framework/Model/Operation/WriteInterface.php: Not used
  11. lib/internal/Magento/Framework/Model/ResourceModel/Db/ProcessEntityRelationInterface.php: Not used
  12. lib/internal/Magento/Framework/Module/ResourceInterface.php: Implementation is deprecated with explanation why
  13. lib/internal/Magento/Framework/View/Asset/SourceFileGeneratorInterface.php: Not used
  14. lib/internal/Magento/Framework/View/Design/Theme/Domain/PhysicalInterface.php: Not used
  15. lib/internal/Magento/Framework/View/Design/Theme/Domain/StagingInterface.php: Not used
  16. lib/internal/Magento/Framework/View/Design/Theme/Domain/VirtualInterface.php: Not used
  17. app/code/Magento/CustomerGraphQl/Api/ValidateCustomerDataInterface.php: GraphQL modules should be extensible via GraphQL schema. They are not domain modules and must not contain Api folder
  18. app/code/Magento/Catalog/Model/EntityInterface.php: Unused interface, exists for 5 years
m2-assistant[bot] commented 3 years ago

Hi @sivaschenko. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

ProkopovVitaliy commented 3 years ago

@magento i am working on this

ProkopovVitaliy commented 3 years ago

@sivaschenko i removed deprecated interfaces here