magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.57k stars 9.32k forks source link

Checkout Shipping form cache don't get empty [Magento 2.4.2] #32336

Closed pcies closed 4 months ago

pcies commented 3 years ago

Preconditions (*)

  1. Magento CE 2.4.2 with sample data is installed.
  2. Tested on 2.4.0, 2.3.5. Issue propably not reproducible in older versions than 2.4.0.

Steps to reproduce (*)

  1. Add Product to cart
  2. Go to checkout
  3. Fill shipping form with random data
  4. Delete data from Address line 1.
  5. delete data from Address line 2.
  6. Refresh page.

Expected result (*)

  1. I expect, that after refreshing form, deleted data will not occur on form after refreshing.
  2. I expect, that after refreshing page, mage-cache-storage with checkout-data shippingAddressFormData will have empty values.

Actual result (*)

  1. Because of some reason, after filling Address line 1 and deleting it's value, it will break caching of all inputs of this form. It is more visible on screenshots below:

  2. Filling shipping form: Screenshot from 2021-03-02 16-46-52

  3. Deleting Data from Address, first line 1 , next line 2: Screenshot from 2021-03-02 16-49-54

  4. Deleting Data from Address first line 2, next line 1: Screenshot from 2021-03-02 16-50-57

  5. Keep updating Address line 1 on keyup till last letter in input: Screenshot from 2021-03-02 16-53-32


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

m2-assistant[bot] commented 3 years ago

Hi @pcies. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 3 years ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

magento-engcom-team commented 3 years ago

:white_check_mark: Confirmed by @engcom-Bravo Thank you for verifying the issue. Based on the provided information internal tickets MC-41161 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

gixid192 commented 3 years ago

I checked and saw that the file is updated based on this PR https://github.com/magento/magento2/commit/b4ee601db5141316c0d268f83e95f32d4e341162#diff-06f8b0bb867918bd12b29c8adaf25535b2c9606103739e4baba2d74c9b2a482f

I don't know how to find the original PR to read full description about it. But the code is there for a reason, maybe we should ask in the original pr/thread?

engcom-Bravo commented 4 months ago

Hi @pcies,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is no more reproducible.Kindly refer the screenshots.

Screenshot 2024-07-15 at 13 15 37 Screenshot 2024-07-15 at 13 16 06 Screenshot 2024-07-15 at 13 17 16

shippingAddressFormData having empty data after deleting data.

Hence we are closing this issue.

Thanks.