magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.55k stars 9.32k forks source link

[Issue] Add EventPrefix and EventObject to checkout agreement model #32510

Open m2-assistant[bot] opened 3 years ago

m2-assistant[bot] commented 3 years ago

This issue is automatically created based on existing pull request: magento/magento2#32451: Add EventPrefix and EventObject to checkout agreement model


Description (*)

Added EvenPrefix and EventObject for checkout agreement model to trigger the event with event prefix.

Related Pull Requests

Fixed Issues (if relevant)

  1. ...

Manual testing scenarios (*)

  1. Add observer for any of the following,
    • sales_agreement_load_before
    • sales_agreement_load_after
    • sales_agreement_save_commit_after
    • sales_agreement_save_before
    • sales_agreement_save_after
    • sales_agreement_delete_before
    • sales_agreement_delete_after
    • sales_agreement_delete_commit_after
    • sales_agreement_clear
  2. Check observer code is executed and also received 'agreement' in event data

Questions or comments

Contribution checklist (*)

yogesh-valiya commented 1 year ago

Test

m2-assistant[bot] commented 4 months ago

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Hotel commented 4 months ago

Hello @yogesh-valiya,

Thanks for the report and collaboration!

We need some more information on this issue as follows:

  1. Please describe the issue you are trying to fix in its related PR.
  2. Any use case you have adding EventPrefix and EventObject
  3. Details steps to reproduce this issue.

Thanks

github-jira-sync-bot commented 3 weeks ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-13252 is successfully created for this GitHub issue.

m2-assistant[bot] commented 3 weeks ago

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.