Closed stephansteiner closed 3 years ago
Hi @stephansteiner. Thank you for your report. To help us process this issue please make sure that you provided the following information:
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
@magento give me 2.4-develop instance
- upcoming 2.4.x release
For more details, please, review the Magento Contributor Assistant documentation.
Please, add a comment to assign the issue: @magento I am working on this
Join Magento Community Engineering Slack and ask your questions in #github channel.
:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
:clock10: You can find the schedule on the Magento Community Calendar page.
:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.
:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel
:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel
@magento give me 2.4-develop instance
Hi @stephansteiner. Thank you for your request. I'm working on Magento instance for you.
Hi @stephansteiner, here is your Magento Instance: https://05a5d3499b4d527537d8f55e02bd75aa-2-4-develop.instances.magento-community.engineering Admin access: https://05a5d3499b4d527537d8f55e02bd75aa-2-4-develop.instances.magento-community.engineering/admin_53b4 Login: eae235fd Password: 78f0a8ff219a
Ok, I could reproduce the issue, but is dependent of the locale setting of the webshop. With locale set to en_US the buttons where displayed correctly with a different locale (example de_DE) the image links are broken. See here for broken Image of checkout with paypal button: https://05a5d3499b4d527537d8f55e02bd75aa-2-4-develop.instances.magento-community.engineering/argus-all-weather-tank.html
The issue seems to be is in the function _getDynamicImageUrl in class \Magento\Paypal\Model\Config: for locales different from en_US the image url is build using
return sprintf(
'https://fpdbs%s.paypal.com/dynamicimageweb?%s',
$this->getValue('sandboxFlag') ? '.sandbox' : '',
http_build_query($params)
);
Apparently https://fpdbs.paypal.com/dynamicimageweb and https://fpdbs.sandbox.paypal.com/dynamicimageweb are both defunct, resulting in the broken image url.
Hi @ajijshekh123. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).Details
If the issue has a valid description, the label Issue: Format is valid
will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid
appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description
label to the issue by yourself.
[ ] 3. Add Component: XXXXX
label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop
branchDetails
- Add the comment @magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop
branch, please, add the label Reproduced on 2.4.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed
once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.
@magento give me 2.4-develop instance
Hi @ajijshekh123. Thank you for your request. I'm working on Magento instance for you.
Hi @ajijshekh123, here is your Magento Instance: https://05a5d3499b4d527537d8f55e02bd75aa-2-4-develop.instances.magento-community.engineering Admin access: https://05a5d3499b4d527537d8f55e02bd75aa-2-4-develop.instances.magento-community.engineering/admin_4e36 Login: 8690ef06 Password: ca31f30c86ca
@ajijshekh123 Hi, I noticed that you're verifying this - please remember to change the shops locale, as the default "en_US" won't display broken image buttons. You may also enter fake data for PayPal credentials as these come only into use when actually clicking the button.
Hi @stephansteiner, I have verified this issue as per your steps and configuration. All configuration I have set up properly but I didn't know which change required on shops local as the default "en_US". Please update the screenshot here. The rest of the configuration I have set up properly and the "Checkout with PayPal" button is showing properly as Expected.
Product Details Page:
Mini Cart:
Thanks.
If PayPal is set to Sandbox Mode, the icons are working, if you disable Sandbox Mode the icon logo is broken again. Sandbox Payment Icon URL: https://fpdbs.sandbox.paypal.com/dynamicimageweb?cmd=_dynamic-image&buttontype=ecshortcut&locale=de_DE Non-Sandbox Version (Broken): https://fpdbs.paypal.com/dynamicimageweb?cmd=_dynamic-image&buttontype=ecshortcut&locale=de_DE
Remember that this affects shops where the locale is set to anythine else but en_US. Please check by changing store locale in Store > Configuration > Locale Options
Hello @stephansteiner, As per defined your configuration, I have reviewed the "Checkout with PayPal" button on the product details page. It is broken and not showing properly.
Thanks.
:white_check_mark: Confirmed by @ajijshekh123
Thank you for verifying the issue. Based on the provided information internal tickets MC-41454
were created
Issue Available: @ajijshekh123, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!
Since March 16th, "Checkout with PayPal" Buttons are not being rendered anymore. The URL for dynamic images from paypal doesn't seem to work anymore.
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
On Product detail page or on cart/minicart, it should show a button with "Checkout with Paypal"
Actual result (*)
The generated code for the image button is:
<input type="image" data-action="checkout-form-submit" data-checkout-url="http://bbq.testwebshop.eu/paypal/express/start/button/1/" src="https://fpdbs.paypal.com/dynamicimageweb?cmd=_dynamic-image&buttontype=ecshortcut&locale=en_GB" alt="Checkout with PayPal" title="Checkout with PayPal">
Only workaround is to set Advanced Settings > Shortcut Buttons Flavor to "static".
Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.