Closed ilnytskyi closed 3 years ago
GeneCommerce provided a patch for their Braintree module here https://github.com/genecommerce/module-braintree-magento2/pull/155/files
I want to help here, but I'm at a loss, should I just implement this:
GeneCommerce provided a patch for their Braintree module here https://github.com/genecommerce/module-braintree-magento2/pull/155/files
On the core payment modules?
Hi @ilnytskyi
Can you please confirm about your query? is it got resolved?
Hi @engcom-Lima. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).Details
If the issue has a valid description, the label Issue: Format is valid
will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid
appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description
label to the issue by yourself.
[ ] 3. Add Component: XXXXX
label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop
branchDetails
- Add the comment @magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop
branch, please, add the label Reproduced on 2.4.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed
once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.
Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).Details
If the issue has a valid description, the label Issue: Format is valid
will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid
appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description
label to the issue by yourself.
[ ] 3. Add Component: XXXXX
label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop
branchDetails
- Add the comment @magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop
branch, please, add the label Reproduced on 2.4.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed
once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.
@ilnytskyi , We are closing this issue as there has been no latest update on the same. Thank you.
Preconditions (*)
Magento core code and module vendors do not care about checking if certain features are enabled or not for checkout. See method https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Checkout/Model/CompositeConfigProvider.php#L35 Vendors add their config classes via DI then magento core code just retrieve all configs in the loop.
It leads to performance degradation in checkout because some
$configProviders
perform requests to external services to init sessions or get some tokens. The issue seem to be complex, because we need either force all vendors to check internally if$configProvider
is allowed or add possibility to configure$this->configProviders
somewhere in admin panel. Now developers can only use DI or plugins for each$configProvider
to disable it (or disable it per store).I think that doing additional check would help to save some CPU and improve page time.
In case of Braintree or Dotpay services we may use only one of payments gateways, but the modules would perform up to 5 requests each. So our checkout page would load forever. Additionally
CompositeConfigProvider
used in bothcheckout/cart
and/checkout
pages. In many stores we finish purchase only on/checkout
page. So those all requests oncheckout/cart
are not necessary.Steps to reproduce (*)
checkout/cart
orcheckout
pageExpected result (*)
Checkout/Model/CompositeConfigProvider.php
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Checkout/Model/CompositeConfigProvider.php#L35Actual result (*)
Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.