Dynamic row system config default values were reset, lost when Enabled/disabled by dependencies fields

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.56k stars 9.32k forks source link

Dynamic row system config default values were reset, lost when Enabled/disabled by dependencies fields #32695

Open tuyennn opened 3 years ago

tuyennn commented 3 years ago

Preconditions (*)

Magento 2.4.2

Steps to reproduce (*)

Add a dynamic row system config depends on a main Yes/No configuration
Add values for dynamic row system config
main Yes/No configuration set: Yes => Save configuration. Check the database: core_config_data
main Yes/No configuration set: No => Save configuration. Check the database: core_config_data
main Yes/No configuration set: Yes => See the values for dynamic row

Expected result (*)

the values for dynamic row after set back to Yes must remain the values that were set before

Actual result (*)

Lost values for dynamic row config, the values on core_config_data is []

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[x] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 3 years ago

Hi @tuyennn. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

lano-vargas commented 3 years ago

I get the same issue with when adding new column to an existing and all previous data row doesn't get rendered, not lost it still in core_config_data table but I assume because the new column isn't in the array it just won't rendered at all is this another issue can anyone confirm ? Thanks

tuyennn commented 3 years ago

@lano-vargas The problem is the fields are not gonna send the values to database while it was disabled. For now I set another template based on vendor/magento/module-config/view/adminhtml/templates/system/config/form/field/array.phtml for the Block extended Magento\Config\Block\System\Config\Form\Field\FieldArray\AbstractFieldArray.

And remove the id from the <table class="admin__control-table"> so it still sends value even with its dependencies disabled Not sure the problem but just a workaround

m2-assistant[bot] commented 3 years ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Bravo commented 3 years ago

We are able to reproduce the issue and hence confirming the issue.

On creation of dependant field dynamic row system config:

core_config_data table status at this point:

Disable the controlling field(parent field) from admin panel and save config:

database table:

Enable the controlling field again in admin panel:

database table:

magento-engcom-team commented 3 years ago

@engcom-Bravo Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

[ ] Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again. Thanks!

magento-engcom-team commented 3 years ago

@m2-community-project[bot] Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

[ ] Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again. Thanks!

magento-engcom-team commented 3 years ago

@m2-community-project[bot] Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

[ ] Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again. Thanks!

magento-engcom-team commented 3 years ago

:white_check_mark: Confirmed by @engcom-Bravo Thank you for verifying the issue. Based on the provided information internal tickets MC-42656 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Kannakiraj123 commented 1 year ago

This js issue.While I was noticed the input fields are disabled when dependent is applied to field.but input hidden field is not disabled.That's why dynamic row's input hidden field value passed to controller save action.

This issue fixed when change below code from vendor/magento/module-config/view/adminhtml/templates/system/config/form/field/array.phtml in line no.41

<input type="hidden" name="<?= $block->escapeHtmlAttr($block->getElement()->getName()) ?>[__empty]" value=""/>

<input type="text" name="<?= $block->escapeHtmlAttr($block->getElement()->getName()) ?>[__empty]" value="" style="display: none;"/>

engcom-November commented 1 month ago

SInce this is quite a old issue, we tried to verify this on latest 2.4-develop and it is still reproducible.

Created a dynamic row system config field dependent on main Yes/No configuration. Please take a look at the screenshot below: 1. Added data into dynamic row when enable field is set to yes.

Same can be seen in core_config_data table.

2. Once the enable field is set to yes after setting it to no, the old data is been reset.

And the core_config_data is empty.

Please find the custom module used to reproduce this issue. DrVendor.zip

Hence reconfirming this.

Thank you.

github-jira-sync-bot commented 1 month ago

:x: Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-803