magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.43k stars 9.29k forks source link

Encoding of ampersands in attribute set group name #32962

Open Footshop-Andy opened 3 years ago

Footshop-Andy commented 3 years ago

When creating a new group of attributes within an attribute set, including an ampersand in the name of the group displays correctly within the "Attribute Set" area of the admin. When viewing a product within the admin, this displays encoded as &

Manually changing the name of the group from & to & will fix the problem; but the next time the attribute set is saved, the problem is re-introduced.

Screenshots from Magento 2.4-develop instance: 1) Creation of group, which looks fine: image

2) This group displays as: image

3) Renaming the group fixes the issue: image

4) But it breaks again if you save the attribute set, even when only editing attributes in other groups: image

Preconditions (*)

  1. Magneto 2.4.2

Steps to reproduce (*)

  1. Create a new group with an ampersand in the name (verify it displays as &)
  2. Rename the group name (double click it) & to & (verify it now displays correctly)
  3. Save the attribute set again, without editing the group, and it breaks again (it displays as &)

Expected result (*)

  1. The attribute set group name can be created using &
  2. The attribute set group name will not be modified when the set is being edited

Actual result (*)

  1. The attribute set group name changes from & to &
m2-assistant[bot] commented 3 years ago

Hi @Footshop-Andy. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Footshop-Andy commented 3 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 3 years ago

Hi @Footshop-Andy. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 3 years ago

Hi @Footshop-Andy, here is your Magento Instance: https://c3643300e426f87072dbfbe4a0cf8dfa-2-4-develop.instances.magento-community.engineering Admin access: https://c3643300e426f87072dbfbe4a0cf8dfa-2-4-develop.instances.magento-community.engineering/admin_645f Login: 9188140e Password: a60fbb904476

m2-assistant[bot] commented 3 years ago

Hi @engcom-Oscar. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Bravo commented 2 months ago

Hi @Footshop-Andy,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Screenshot 2024-06-17 at 09 18 54

The attribute set group name changes from & to &

Hence Confirming the issue.

Thanks.

github-jira-sync-bot commented 2 months ago

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

github-jira-sync-bot commented 2 months ago

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

github-jira-sync-bot commented 2 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12163 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 months ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

github-jira-sync-bot commented 1 month ago

:x: Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-12163