magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.3k forks source link

Checkout: Region select autofillable even if Allow to Choose State if It is Optional for Country is set to No #33437

Open mattijv opened 3 years ago

mattijv commented 3 years ago

Preconditions (*)

  1. Magento 2.4.2 with sample data
  2. United States removed from General > General > State Options > State is Required for
  3. Allow to Choose State if It is Optional for Country is set to No

Screenshot from 2021-07-07 11-33-47

  1. Browser has an address saved with United States as the country and California as the region (e.g. go to Settings > Autofill > Addresses and more in Chrome and add an address in United States and California as the region). I only tested this with Chrome, unsure if other browsers are affected.

Screenshot from 2021-07-07 11-39-58

Note: the country can be any country with regions, this is just an example.

Steps to reproduce (*)

  1. Add item to the cart
  2. Go to the checkout and apply the autofill to the shipping address (in Chrome start typing the name you selected and it should prompt for the autofill).
  3. Select shipping method and go to the next step

Screenshot from 2021-07-07 11-34-33

Expected result (*)

  1. The region input is NOT filled.

Screenshot from 2021-07-07 12-10-13

Actual result (*)

  1. The region input IS filled.

Screenshot from 2021-07-07 11-34-51

This is problematic as the customer can't see the field and does not know if a wrong region is filled there. We have several orders that have the wrong region in the address as a result of this.


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

m2-assistant[bot] commented 3 years ago

Hi @mattijv. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 3 years ago

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Hotel commented 3 years ago

Hi @mattijv,

We have followed the exact steps, you have mentioned in the description. But we are unable to reproduce the issue. We are getting region name on checkout page. Please find below screenshot for reference:

Screenshot 2021-07-07 at 3 23 38 PM Screenshot 2021-07-07 at 3 24 37 PM

Let us know if any other step(s), you have followed.

Thanks

mattijv commented 3 years ago

@engcom-Hotel Thank you for taking a look, but by your own screenshots you show that you have in fact managed to reproduce the issue: there is no region field visible on the checkout but the region is autofilled to the address. That is the problem.

ghost commented 3 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 3 years ago

Hi @konrad-szwed-accenture. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 3 years ago

Hi @konrad-szwed-accenture, here is your Magento Instance: https://5f6ee931e8c5f93b427faf2f2084946f-2-4-develop.instances.magento-community.engineering Admin access: https://5f6ee931e8c5f93b427faf2f2084946f-2-4-develop.instances.magento-community.engineering/admin_4339 Login: 95d97fa4 Password: ee76bb5fa1aa

mattijv commented 3 years ago

@engcom-Hotel Any updates on this? Can you look over your results again and confirm that you are able to reproduce the issue, like your screenshots show?

engcom-Hotel commented 3 years ago

Hello @mattijv,

I think there might be some confusion. As per my screenshot, the region with the name "California" is visible. And this is also mentioned in your "Actual Result".

Can you please let us know if we need to further work on this ticket?

Thanks

mattijv commented 3 years ago

@engcom-Hotel Yes, unfortunately there seems to be confusion. In bug reports the Expected Result and Actual Result are treated as follows:

  1. Expected Result: the correct result that SHOULD happen, but DOES NOT
  2. Actual Result: the buggy incorrect result that SHOULD NOT happen, but DOES

Your screenshots show that you do indeed get the same result for Actual Result that I do, which is the incorrect and buggy behavior; the region California should not appear, because there is no (visible) input for it.

mattijv commented 3 years ago

@engcom-Hotel Any updates? Can you confirm that you see the region in the final address and mark this as reproducible?

engcom-Hotel commented 3 years ago

Hello @mattijv,

As per the mentioned steps in the description, the issue has been reproducible. So we are confirming this ticket.

Thanks

magento-engcom-team commented 3 years ago

@engcom-Hotel Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

Once all required information is added, please add label "Issue: Confirmed" again. Thanks!

magento-engcom-team commented 3 years ago

:white_check_mark: Confirmed by @engcom-Hotel Thank you for verifying the issue. Based on the provided information internal tickets MC-43024 were created

Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Melnychuk-Alexandr commented 2 years ago

@magento I am working on this

stephansteiner commented 2 years ago

Hi, any progress on this?

kasperth commented 1 year ago

Still an issue in Magento 2.4.5-p1. Any update to this?

engcom-Bravo commented 3 months ago

Hi @mattijv,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Screenshot 2024-06-24 at 10 47 44 Screenshot 2024-06-24 at 10 47 53

We are able to see the Region field.

Hence Confirming the issue.

Thanks.

github-jira-sync-bot commented 3 months ago

:x: Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-782

mattijv commented 3 months ago

@engcom-Bravo Thank you for confirming this again, though it was already confirmed once back in 2021.

Hopefully two confirmations is enough to get this in the issue queue.