magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.31k forks source link

State input is the wrong type on checkout #33472

Closed andreifurrnica closed 3 years ago

andreifurrnica commented 3 years ago

Preconditions (*)

  1. Magento 2.4.2-p1
  2. int Stores -> Configuraton -> General -> General -> Default country chose a default country a country with mandatory state and predefined list of states (such as Romania)
  3. in Stores -> Configuraton -> General -> General set -> Allow countries select only the same country as above
  4. enable in store pickup shipping method
  5. add inventory source and set is a pickup location

Steps to reproduce (*)

  1. add product to cart
  2. go to checkout
  3. do not complete shipping address
  4. select in store pickup
  5. select store
  6. select other shipping method so the shipping address form is shown

Expected result (*)

  1. state field is a dropdown with allowed states for the default country

Actual result (*)

  1. state field is text input

The only fix i was able to found is to select more than one country in the Allowed countries field


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

andreifurrnica commented 3 years ago

@magento give me 2.4.2-p1 instance

magento-deployment-service[bot] commented 3 years ago

Hi @andreif23. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 3 years ago

Hi @andreif23, here is your Magento Instance: https://f1ef6d87d0fb902692ffdb2980b47fb1-2-4-2-p1.instances.magento-community.engineering Admin access: https://f1ef6d87d0fb902692ffdb2980b47fb1-2-4-2-p1.instances.magento-community.engineering/admin_80a2 Login: 4af7e175 Password: 0c90ac230027

m2-assistant[bot] commented 3 years ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-November commented 3 years ago

Unable to verify this issue on Magneto 2.4-develop branch as add inventory source and In-store pickup shipping method options are not available in 2.4-develop branch. Hence verified this issue on Magento 2.4.2-p1 version and the issue is reproducible: Steps:

  1. Admin -> Stores -> Configuraton -> General -> General -> Default country chose a default country a country with mandatory state and predefined list of states (such as Romania)
  2. Stores -> Configuraton -> General -> General set -> Allow countries select only the same country as above.
  3. State Options - State is Required for "Romania"
  4. Enable in store pickup shipping method (Stores - Configuration - Sales - Delivery Methods - In Store Delivery)
  5. Add inventory source and enable use as a pickup location (Stores - Inventory - Sources)
  6. Add new Stock and assign source (Stores - Inventory - Stocks)
  7. Clear Cache, Reindex
  8. Create a new simple product and assign the newly created source (Catalog - Products)
  9. Front-end - Login to the website using customer having shipping address saved already
  10. Add this product to cart
  11. Go to checkout
  12. Do not complete shipping address
  13. select In Store pickup Delivery
  14. Select store. (Try entering zip-code or city and clear the values )Issue 1: Store is not displayed on typing city or postcode. User is able to select the store after clearing the values.
  15. Click on "Shipping" button again
  16. select other shipping method so the shipping address form is shown Ex: Free or Flat Rate
  17. If Shipping Address is pre-selected, click on "+New Address" button Issue: State field is text input but not a drop down image

image

Expected behavior: State field should be a dropdown image

magento-engcom-team commented 3 years ago

:white_check_mark: Confirmed by @engcom-November Thank you for verifying the issue. Based on the provided information internal tickets MC-42863 were created

Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

engcom-November commented 3 years ago

Verified the issue again on Magento 2.4-develop branch by installing inventory-metapackage (ref link) and the issue is not reproducible: Steps:

  1. Admin -> Stores -> Configuraton -> General -> General -> Default country chose a default country a country with mandatory state and predefined list of states (such as Romania)
  2. Stores -> Configuraton -> General -> General set -> Allow countries select only the same country as above.
  3. State Options - State is Required for "Romania"
  4. Enable in store pickup shipping method (Stores - Configuration - Sales - Delivery Methods - In Store Delivery)
  5. Add inventory source and enable use as a pickup location (Stores - Inventory - Sources)
  6. Add new Stock and assign source (Stores - Inventory - Stocks)
  7. Clear Cache, Reindex
  8. Create a new simple product and assign the newly created source (Catalog - Products)
  9. Front-end - Login to the website using customer
  10. Add this product to cart
  11. Go to checkout
  12. Do not complete shipping address
  13. select In Store pickup Delivery
  14. Select store.
  15. Click on "Shipping" button again
  16. select other shipping method so the shipping address form is shown Ex: Free or Flat Rate
  17. If Shipping Address is pre-selected, click on "+New Address" button No issue: State field is a drop-down but not a text field. @andreif23, kindly re-check the issue on 2.4-develop branch and provide missing steps if the issue is still reproducible. Thank you.
engcom-November commented 3 years ago

@andreif23, we are closing this issue as there has been no latest update on the same. Thank you.