Dropped functionality: Ability to set "empty text" for UI Component listings

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.59k stars 9.32k forks source link

Dropped functionality: Ability to set "empty text" for UI Component listings #33473

Open Pinchanzee opened 3 years ago

Pinchanzee commented 3 years ago

In Magento1 it was possible to change the text displayed in the dummy empty grid row, by setting _emptyText. In Magento2 this is hardcoded for UI Components to "We couldn't find any records." in /module-ui/view/base/web/templates/grid/listing.html

Would it be difficult to implement this as a feature of the component's XML?

m2-assistant[bot] commented 3 years ago

Hi @Pinchanzee. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 3 years ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Delta commented 3 years ago

Hi @Pinchanzee, Kindly provide the steps to reproduce the issue, Expected results and Actual results.

Thanks

Pinchanzee commented 3 years ago

This is a feature request, reproduction steps are not applicable

On Thu, 15 Jul 2021, 11:35 Penchalaiah K, @.***> wrote:

Hi @Pinchanzee https://github.com/Pinchanzee, Kindly provide the steps to reproduce the issue, Expected results and Actual results.

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/magento/magento2/issues/33473#issuecomment-880587194, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPBRUI6VIORON5HUDOQU5LTX22WBANCNFSM5AJA2ANA .

mrtuvn commented 3 years ago

wonder why do you not replace in custom module or custom theme in admin That template belong to js ui component Magento/Ui/view/base/web/js/grid/listing.js. In specific case you can extend/override this component or build new one for your requirement

Pinchanzee commented 3 years ago

Yes I could do this, but I'm not really that passionate about it for my particular use case.

I just think it's a useful feature to have dropped in the migration to UI Components that likely wasn't recorded anywhere.

On Mon, 19 Jul 2021, 10:25 Tu Nguyen, @.***> wrote:

wonder why do you not replace in custom module or custom theme in admin

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/magento/magento2/issues/33473#issuecomment-882395230, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPBRULQ74R2Z45YSE6BUOLTYPVPJANCNFSM5AJA2ANA .

engcom-Delta commented 3 years ago

Hi @Pinchanzee,

Kindly provide use cases for this feature request.

Thanks

Pinchanzee commented 3 years ago

Any time a grid is empty, it can be helpful to provide the user with more feedback.

Cases where a grid is not being used as a record searching tool. Eg Grid of ERP picking sessions that when empty says "Nothing is currently being picked right now" rather than "We couldn't find any records" - the latter is confusing to the end user when nothing is being searched for.
Where you want to provide helpful information for the end user when there are no results. Eg. "No results, last synced [date]". Or "No results. If you are instead looking for [X] be sure to check [Y]"

engcom-Delta commented 3 years ago

Hi @Pinchanzee , We have noticed that steps to reproduce the issue, actual results and expected results are missing. Kindly provide them.

Thanks

Pinchanzee commented 3 years ago

Reproduction steps aren't applicable here, more of a feature request

github-jira-sync-bot commented 3 years ago

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

github-jira-sync-bot commented 3 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-1189 is successfully created for this GitHub issue.

m2-assistant[bot] commented 3 years ago

:white_check_mark: Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.