Template file retrieving should be store scoped

alexmtch commented 3 years ago

Preconditions (*)

Magento 2.3.6 or lower (maybe greater)

Steps to reproduce (*)

Setup Multiple Stores/websites in Magento Create 2 different Stock Alert Email Templates for each store (Marketing - Communications - Email Templates - Add New Template) Enable Product Alerts and Apply the newly created templates for each Store Stores - Configuration - Catalog - Catalog - Product Alerts - Stock Alert Email Template - Set the new template created for new Store view scope , "Allow Alert When Product Comes Back in Stock" - Yes Default Scope: Product Alerts Run Settings - Give the Start time and Save Configuration Change the Scope of Store View to another Store view and apply other newly created template and save the configuration Reindex and clear cache Admin - Add a new Product - Set the Product to Out Of Stock and Save Front-end - New Store website (for ex: France website) - Sign in as customer - Product Details page - Click on "Notify me when this product is in stock" Open the same Product in different Store (for ex: Germany website) - Sign in as same customer - Product Details page - Click on "Notify me when this product is in stock" Admin - Edit the same product and Set the stock status to "In Stock" and Save Run the Cron > php bin/magento cron:run Verify emails of both the Stores

Expected result (*)

Each email should have the right template

Actual result (*)

Only the first processed store template is serving

Workaround

I found out that it's caused by \Magento\Framework\View\Element\Template\File\Resolver::getTemplateFileName In this case, the $key to store the template and avoid multiple times the same process to run is the concatenation of the template identifier with params given by \Magento\Framework\View\Element\Template.

In this case i recommend in \Magento\Framework\View\Element\Template::getTemplateFile to add in parameters the store id in parameters by this way :

$params = ['module' => $this->getModuleName()]; could be

$params = [
            'module' => $this->getModuleName(),
            'store_id' => $this->_storeManager->getStore()->getId()
        ];

or

$store = $this->_storeManager->getStore();
        $params = [
            'module' => $this->getModuleName(),
            'store_id' => $store ? $store->getId() : \Magento\Store\Model\Store::DEFAULT_STORE_ID
        ];

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[x] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 3 years ago

Hi @alexmtch. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 3 years ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Delta commented 3 years ago

Hi @alexmtch,

Please provide more clarity on the step# 'Run the catalog_product_alert CRON'. How to run the alert CRON? Hence added the label 'Needs Update'

Thanks

alexmtch commented 3 years ago

Hi @engcom-Delta You could run cron job from magento by following this documentation

This cron job is provided by the module Magento_ProductAlert. You could use tools like bin/magento or magerun to help you to run the cron individually.

m2-assistant[bot] commented 3 years ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-November commented 3 years ago

Verified the issue on Magento 2.4-develop branch and the issue is not reproducible: Steps performed:

Setup Multiple Stores/websites Ref link
Create 2 different templates for each store for the template (Marketing - Communications - Email Templates - Add New Template)
Enable Product Alerts and Apply the newly created templates for each Store Stores - Configuration - Catalog - Catalog - Product Alerts - Stock Alert Email Template - Set the new template created for new Store view scope , "Allow Alert When Product Comes Back in Stock" - Yes
Default Scope: Product Alerts Run Settings - Give the Start time and Save Configuration
Change the Scope of Store View to another Store view and apply other newly created template and save the configuration
Reindex and clear cache
Admin - Add a new Product - Set the Product to Out Of Stock and Save
Front-end - New Store website (for ex: France website) - Sign in as customer - Product Details page - Click on "Notify me when this product is in stock"
Open the same Product in different Store (for ex: Germany website) - Sign in as same customer - Product Details page - Click on "Notify me when this product is in stock"
Admin - Edit the same product and Set the stock status to "In Stock" and Save
Run the Cron > php bin/magento cron:run
Verify emails of both the Stores - No issue: Different templates are applied to both the stores in the emails

@alexmtch , kindly recheck the issue on Magento 2.4-develop branch and provide missing steps if any if the issue is still reproducible. Thank you.

alexmtch commented 3 years ago

Hello @engcom-November

Have you tried on Magento 2.3.6 ?
Have you enabled cache ?
Have you 2 different Magento_ProductAlert::email/stock.phtml for each stores ? (So 2 different themes serving 2 different templates files)

Ah you could see in \Magento\Framework\View\Element\Template\File\Resolver::getTemplateFileName the template path is stored and no process could define the difference between 2 store template file path.

The process you made seems to be good to reproduce the bug.

engcom-November commented 3 years ago

Verified the issue again on Magento 2.4-develop branch and the issue is reproducible: Steps to reproduce:

Setup Multiple Stores/websites in Magento
Create 2 different Stock Alert Email Templates for each store (Marketing - Communications - Email Templates - Add New Template)
Enable Product Alerts and Apply the newly created templates for each Store Stores - Configuration - Catalog - Catalog - Product Alerts - Stock Alert Email Template - Set the new template created for new Store view scope , "Allow Alert When Product Comes Back in Stock" - Yes
Default Scope: Product Alerts Run Settings - Give the Start time and Save Configuration
Change the Scope of Store View to another Store view and apply other newly created template and save the configuration
Reindex and clear cache
Admin - Add a new Product - Set the Product to Out Of Stock and Save
Front-end - New Store website (for ex: France website) - Sign in as customer - Product Details page - Click on "Notify me when this product is in stock"
Open the same Product in different Store (for ex: Germany website) - Sign in as same customer - Product Details page - Click on "Notify me when this product is in stock"
Admin - Edit the same product and Set the stock status to "In Stock" and Save
Run the Cron > php bin/magento cron:run
Verify emails of both the Stores Issue: Only one Stock Alert email is getting triggered for particular Store (first processed store template) Note: There is no issue with Price Alert emails - 2 Emails are triggered for both the Stores.

github-jira-sync-bot commented 3 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-1099 is successfully created for this GitHub issue.

m2-assistant[bot] commented 3 years ago

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

github-jira-sync-bot commented 3 years ago

:x: Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.magento.com/browse/AC-1099

LexKoomen commented 2 years ago

Any update on this?

topanok commented 2 years ago

@magento I am working on this

magento / magento2