magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.57k stars 9.32k forks source link

B2B prices in quote add VAT each time page reload #33619

Closed AMishchan closed 3 years ago

AMishchan commented 3 years ago

Preconditions (*)

  1. Enabled magento/extension-b2b and magento/module-negotiable-quote functional
  2. Set Stores->Configuration->Sales->Tax->Calculation Settings->Catalog Price to "Including Tax"

Steps to reproduce (*)

1.Add product to cart

  1. On a cart page click "Request a Quote"
  2. Open quote in admin panel and add "Negotiated Price", "Amount Discount" for example. Click "Send".
  3. Open Quote in a customer account, after each page reload prices increase according to VAT (10% in this case).
  4. Reply for a quote with a comment on a customer account quote page (in this case after reply submit totals do not increase but totals starts increase on a admin panel quote page)
  5. Reply and click "Send" from admin page -> totals starts increase on a customer account quote page again.
  6. Set Stores->Configuration->Sales->Tax->Calculation Settings->Catalog Price to "Excluding Tax" and totals calculates correct.

Expected result (*)

  1. Quote Calculate Quote Calculate  (1) Quote Calculate  (2) My Quotes Quote #13 _ Oper Quote #13 _ Oper (1)

  2. Totals do not increase in any case after page reload

Actual result (*)

  1. [Screenshots, logs or description] 2.Totals increase after each page reload

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

m2-assistant[bot] commented 3 years ago

Hi @Zayander. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

AMishchan commented 3 years ago

My composer.json file content: { "name": "magento/project-enterprise-edition", "description": "eCommerce Platform for Growth (Enterprise Edition)", "type": "project", "license": [ "proprietary" ], "config": { "preferred-install": "dist", "sort-packages": true }, "version": "2.4.2-p1", "require": { "magento/composer-root-update-plugin": "~1.1", "magento/extension-b2b": "^1.3", "magento/module-negotiable-quote": "^100.3", "magento/product-enterprise-edition": ">=2.4.2 <2.4.3" }, "autoload": { "exclude-from-classmap": [ "/dev/", "/update/", "/Test/" ], "files": [ "app/etc/NonComposerComponentRegistration.php" ], "psr-0": { "": [ "app/code/", "generated/code/" ] }, "psr-4": { "Magento\": "app/code/Magento/", "Magento\Framework\": "lib/internal/Magento/Framework/", "Magento\Setup\": "setup/src/Magento/Setup/", "Zend\Mvc\Controller\": "setup/src/Zend/Mvc/Controller/" } }, "require-dev": { "allure-framework/allure-phpunit": "~1.2.0", "dealerdirect/phpcodesniffer-composer-installer": "^0.7.0", "friendsofphp/php-cs-fixer": "~2.16.0", "lusitanian/oauth": "~0.8.10", "magento/magento-coding-standard": "", "magento/magento2-functional-testing-framework": "^3.0", "pdepend/pdepend": "~2.7.1", "phpcompatibility/php-compatibility": "^9.3", "phpmd/phpmd": "^2.8.0", "phpstan/phpstan": ">=0.12.3 <=0.12.23", "phpunit/phpunit": "^9", "sebastian/phpcpd": "~5.0.0", "squizlabs/php_codesniffer": "~3.5.4" }, "conflict": { "gene/bluefoot": "" }, "autoload-dev": { "psr-4": { "Magento\PhpStan\": "dev/tests/static/framework/Magento/PhpStan/", "Magento\Sniffs\": "dev/tests/static/framework/Magento/Sniffs/", "Magento\TestFramework\Inspection\": "dev/tests/static/framework/Magento/TestFramework/Inspection/", "Magento\TestFramework\Utility\": "dev/tests/static/framework/Magento/TestFramework/Utility/", "Magento\Tools\": "dev/tools/Magento/Tools/", "Magento\Tools\Sanity\": "dev/build/publication/sanity/Magento/Tools/Sanity/" } }, "minimum-stability": "dev", "prefer-stable": true, "repositories": { "0": { "type": "composer", "url": "https://repo.magento.com/" } }, "extra": { "magento-force": "override", "patches-search": "patches" } }

m2-assistant[bot] commented 3 years ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-November commented 3 years ago

Verified the issue on Magento 2.4-develop branch having B2B Modules enabled and the issue is not reproducible:

Steps performed:

Admin - Stores - Configuration - General - Enable B2B Features and Save Stores->Configuration->Sales->Tax->Calculation Settings->Catalog Price to "Including Tax" Create Tax Zone and Tax Rule of Ex: Say 10% (Stores - Taxes) Create a Company Account (Customers - Company - Add New Company) Reset password - Customers - All Customers - Edit the customer - Reset Password Login to Store-front as a Company Administrator Add a product to Cart Navigate to Shopping Cart Page - Click on Request a Quote - Send Request Open the Quote from Admin - Sales - Quotes - View Quote - add "Negotiated Price" - "Amount Discount" for example. Click "Send". Open Quote in a customer account (Front-end) - No issue in Price Total displayed as expected. Refresh the page - No issue

  1. Reply for a quote with a comment on a customer account quote page (Front-end)
  2. Reply and click "Send" from admin page -> No issue. Price values are displayed as expected in both Front end and admin pages
  3. Reload the page - No issue

image image

@Zayander, Kindly recheck the issue on Magento 2.4-develop branch and provide the missing steps if any if the issue is still reproducible. Thank you

engcom-November commented 3 years ago

@AMishchan, we are closing this issue as there has been no latest update on the same. Thank you.