Unable to place order after applying discount code in review & payment checkout step and if this affects shipping method selected previously

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.5k stars 9.3k forks source link

Unable to place order after applying discount code in review & payment checkout step and if this affects shipping method selected previously #33697

Closed emiliatereanu closed 2 years ago

emiliatereanu commented 3 years ago

Preconditions (*)

Magento 2.4.2

Steps to reproduce (*)

Enable free shipping delivery method with condition minimum order amount value 200 ( for example)
Create a cart price rule with voucher code that gives a fixed amount
Add product(s) to cart so that cart amount is greater or equal than 200
Proceed to checkout, fill address, then select the free shipping delivery method.
Proceed to payment step. Choose a payment method, Check/Money order for example
Apply discount code, making sure now the total amount is less than what free shipping requires.
Try to place order.
User gets an error "The shipping method is missing. Select the shipping method and try again." Message fades after a few seconds.

Expected result (*)

User is redirected to previous Shipping step and is informed to select one of the available delivery methods.

Actual result (*)

User is stuck in review & payment step and is displayed an error message, that fades after a few seconds: "The shipping method is missing. Select the shipping method and try again."

Additional information

Mentioned in https://github.com/magento/magento2/issues/29938

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 3 years ago

Hi @emiliatereanu. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

emiliatereanu commented 3 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 3 years ago

Hi @emiliatereanu. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 3 years ago

Hi @emiliatereanu, here is your Magento Instance: https://05583d095a9f04bca87282551c8254f7-2-4-develop.instances.magento-community.engineering Admin access: https://05583d095a9f04bca87282551c8254f7-2-4-develop.instances.magento-community.engineering/admin_f13b Login: 418d0c8d Password: 0d8a220de4e3

m2-assistant[bot] commented 3 years ago

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

emiliatereanu commented 3 years ago

I confirm this is reproducing on 2.4-develop issue_reproducing_develop

m2-assistant[bot] commented 3 years ago

Hi @engcom-Echo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Echo commented 3 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 3 years ago

Hi @engcom-Echo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 3 years ago

Hi @engcom-Echo, here is your Magento Instance: https://05583d095a9f04bca87282551c8254f7-2-4-develop.instances.magento-community.engineering Admin access: https://05583d095a9f04bca87282551c8254f7-2-4-develop.instances.magento-community.engineering/admin_e429 Login: e11900e8 Password: ec6977b389d4

github-jira-sync-bot commented 3 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-937 is successfully created for this GitHub issue.

m2-assistant[bot] commented 3 years ago

:white_check_mark: Confirmed by @engcom-Echo. Thank you for verifying the issue.
Issue Available: @engcom-Echo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

engcom-Echo commented 3 years ago

This issue is reproducible on 2.4-develop branch, with the given steps to reproduce in the issue description. Would like to highlight few points w.r.t issue

The Error message displayed to the user "The shipping method is missing. Select the shipping method and try again." , seems very confusing from user perspective, considering the fact that the user had already selected his/her shipping method on the previous(shipping) page.
In the scenario mentioned in the issue, the user has to be redirected back to the page where he/she can choose other shipping methods.
Also in the scenario mentioned in the issue if the user uses the back button from the browser and navigate back from the review & payments page to the shipping page, the free shipping method which the user had earlier selected is missing from the choices(as the coupon has been applied by now), without any message or indications to the user, which could be perplexing.