Billing Address Form does not preload billing address after page refresh when Display Billing Address On is set Payment Page

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.55k stars 9.32k forks source link

Billing Address Form does not preload billing address after page refresh when Display Billing Address On is set Payment Page #33899

Open abude opened 3 years ago

abude commented 3 years ago

Preconditions (*)

Magento 2.4.2
Vanilla, clean install with sample-data

Steps to reproduce (*)

Go to admin -> store -> config -> sales -> checkout and set Display Billing Address On to Payment Page
Go to frontend -> add any product to the cart
Go to checkout and fill email, shipping address and choose shipping method
Go to payment step, uncheck My billing and shipping address are the same
Fill new address in the billing address form and click update
Now, refresh the page and click edit on the billing address
Form is empty, without values.

Video: https://www.dropbox.com/s/qqplkwkaqbo0phz/billingAddress-issue.mov?dl=0

Expected result (*)

After filling in the billing address form a different billing address than shipping address and refreshing the page, it should preload the data of the billing address in the form.
Data is there, in the localStorage

PS. all the other components are preloaded: email, shipping address, shipping method, payment method.

Actual result (*)

Form of billing address after refresh page is not preloading the previously saved billing address, which is different than the shipping address.

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[x] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 3 years ago

Hi @abude. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 3 years ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Delta commented 3 years ago

Hi @abude ,

We verified the issue on Magento2.4 Develop, it is not reproducible . we could see that after refresh data is being loaded. Please find the attached snapshots for reference. Pre-filled

Kindly request to reverify from your end once again and please confirm.

thanks

abude commented 3 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 3 years ago

Hi @abude. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 3 years ago

Hi @abude, here is your Magento Instance: https://8115e78137a8010c7a48737baece4047-2-4-develop.instances.magento-community.engineering Admin access: https://8115e78137a8010c7a48737baece4047-2-4-develop.instances.magento-community.engineering/admin_2327 Login: c97ee737 Password: cae3c3559a3a

abude commented 3 years ago

hello @engcom-Delta,

Thanks for the update, I was able to replicate the issue in the 2.4-develop instance.

Are you sure you did this: Go to admin -> store -> config -> sales -> checkout and set Display Billing Address On to Payment Page

Are you sure you tried the form if the billing address and not the shipping address?

Thank you!

engcom-Delta commented 3 years ago

@magento give me 2.4.2 instance

magento-deployment-service[bot] commented 3 years ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 3 years ago

Hi @engcom-Delta, here is your Magento Instance: https://8115e78137a8010c7a48737baece4047-2-4-2.instances.magento-community.engineering Admin access: https://8115e78137a8010c7a48737baece4047-2-4-2.instances.magento-community.engineering/admin_0095 Login: 0a4ea197 Password: e3577cd83d57

engcom-Delta commented 3 years ago

Hi @abude , Issue is reproducible on Magento 2.4.2 instance & Magento 2.4 Develop. Hence adding the label 'Issue confirmed'. Kindly find the attached screenshots for reference.

Go to admin -> store -> config -> sales -> checkout and set Display Billing Address On to Payment Page
Go to frontend -> add any product to the cart
Go to checkout and fill email, shipping address and choose shipping method
Go to payment step, uncheck My billing and shipping address are the same
Fill new address in the billing address form and click update
Now, refresh the page and click edit on the billing address
Form is empty, without values.

m2-assistant[bot] commented 3 years ago

Hi @engcom-Delta. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
1. Verify that the issue is reproducible on 2.4-develop branch
  Details
  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
1. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

ThomasNegeli commented 3 years ago

@engcom-Delta this issue is not Admin UI related. Please remove the label.

Usik2203 commented 2 years ago

@magento I am working on this

gexxx05 commented 1 year ago

I have investigated the issue on M2.4.4 and found the following behaviour. In my example I am using the payment method checkmo. The affected file: https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Checkout/view/frontend/web/js/view/payment/default.js

Display Billing Address On to Payment Method: The billingAddressCode on line 68 is billingAddresscheckmo. In checkoutProvider there is an empty address object for each payment method called billingAddress + payment code, so in our case it will be billingAddresscheckmo. On line 72 defaultAddressData is not undefined because our billingAddressCode exists in checkoutProvider and so billingAddressData will be the previously added billing address. Everything works fine here.
Display Billing Address On to Payment Page: billingAddressCode on line 68 will be billingAddresscheckmo. In checkoutProvider there is a single empty address object called billingAddressshared. On line 72 defaultAddressData is undefined because our billingAddressCode doesn't exist in checkoutProvider, so we run in the return statement and previously added billing address is not inserted.

The problem is, that billingAddressCode will stay billingAddress + payment code but the object in checkoutProvider changes name to billingAddress + shared.

I don't know if this is the best solution, but if we change line 68 to billingAddressCode = 'billingAddress' + (window.checkoutConfig.displayBillingOnPaymentMethod ? this.getCode() : 'shared'); everything will work as expected.

engcom-Bravo commented 3 months ago

Hi @abude,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the attached video.

https://github.com/user-attachments/assets/326fab75-9f35-48ed-a477-4a99d7fd4d6e

NOTE : without refreshing the page it is working fine.

Hence Confirming the issue.

Thanks.

gexxx05 commented 3 months ago

Thanks @engcom-Bravo, the solution is right here: https://github.com/magento/magento2/issues/33899#issuecomment-1401550007

github-jira-sync-bot commented 3 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12539 is successfully created for this GitHub issue.

m2-assistant[bot] commented 3 months ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.