magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.56k stars 9.32k forks source link

Update `phpgt/dom` composer dependency for `magento/magento2-page-builder` extension #34096

Closed andrewbess closed 3 years ago

andrewbess commented 3 years ago

We checked fatal errors with environment PHP 8. One of the problems is incompatible composer dependency - phpgt/dom in magento/magento2-page-builder extension. We need to upgrade phpgt/dom composer dependency to the next versions "~2.2.1||~3.0.0" and check it again.

Expected result (*)

  1. The system has no fatal errors

Actual result (*)

  1. Declaration of Gt\Dom\ChildNode::before(DOMNode $node): void must be compatible with DOMElement::before(...$nodes): void in /var/www/html/vendor/phpgt/dom/src/Element.php on line 29
m2-assistant[bot] commented 3 years ago

Hi @andrewbess. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

xmav commented 3 years ago

@magento export issue to Jira project AC as Story

andrewbess commented 3 years ago

Changes have been delivered