search

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.56k stars 9.32k forks source link

Make PageBuilder compatible with PHP8 #34131

Closed github-jira-sync-bot closed 3 years ago

github-jira-sync-bot commented 3 years ago

Goal of this task to make PageBuilder compatible with PHP8. In scope of this ticket PHP8 compatibility issues should be detected and resolved.

One of the known problems at the moment is a dependency to phpgt/dom library. This library does not have version compatible with both PHP versions (7.4 & 8). At the same time phpgt/dom 3.x(compatible with PHP8) has significant difference from v2.2.x(compatible with PHP7.4) so that we cannot declare dependency to it using OR: <sub>``2``.``2``.``1``||</sub>3.0.0

 

AC:

github-jira-sync-bot commented 3 years ago

The issue was exported from the internal Jira. The link to the original Jira issue: https://jira.corp.magento.com/browse/AC-1300

m2-assistant[bot] commented 3 years ago

Hi @github-jira-sync-bot. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

andrewbess commented 3 years ago

This issue has been fixed in PR https://github.com/magento/magento2-page-builder/pull/783