Open ia-gaurav opened 3 years ago
Hi @ia-gaurav. Thank you for your report. To help us process this issue please make sure that you provided the following information:
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
@magento give me 2.4-develop instance
- upcoming 2.4.x release
For more details, please, review the Magento Contributor Assistant documentation.
Please, add a comment to assign the issue: @magento I am working on this
Join Magento Community Engineering Slack and ask your questions in #github channel.
:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
:clock10: You can find the schedule on the Magento Community Calendar page.
:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.
:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel
:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel
the fix maybe take times even a years to deploy/merge into codebase i think you can workarounds and patch with your own way https://stackoverflow.com/questions/60357083/does-not-use-passive-listeners-to-improve-scrolling-performance-lighthouse-repo Add web/jquery.js to your theme instead modify core. Add some patch at bottom
Personally I've been using the following patch on jquery for ages:
require(['jquery'], function(jQuery) {
'use strict';
(function() {
jQuery.event.special.touchstart = {
setup: function(_, ns, handle) {
this.addEventListener('touchstart', handle, {passive: ns.includes('noPreventDefault') ? true : false});
}
};
jQuery.event.special.touchmove = {
setup: function(_, ns, handle) {
this.addEventListener('touchmove', handle, {passive: ns.includes('noPreventDefault') ? true : false});
}
};
}());
});
Add to the file lib/web/jquery/patches/jquery.js
Created pr for jquery newer version here https://github.com/magento/magento2/pull/34162
@ia-gaurav See my link above
@mrtuvn - can u tell what to add in lib/web/jquery/patches/jquery.js
Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).Details
If the issue has a valid description, the label Issue: Format is valid
will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid
appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description
label to the issue by yourself.
[ ] 3. Add Component: XXXXX
label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop
branchDetails
- Add the comment @magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop
branch, please, add the label Reproduced on 2.4.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed
once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.
@magento give me 2.4-develop instance
Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.
Hi @engcom-Hotel, here is your Magento Instance: https://6dd90eea1a8e2a0fc4db3ee65e365b93-2-4-develop.instances.magento-community.engineering Admin access: https://6dd90eea1a8e2a0fc4db3ee65e365b93-2-4-develop.instances.magento-community.engineering/admin_b01d Login: ef808a7f Password: 82a61d380e70
@magento give me 2.4-develop instance
Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.
Hi @engcom-Hotel, here is your Magento Instance: https://6dd90eea1a8e2a0fc4db3ee65e365b93-2-4-develop.instances.magento-community.engineering Admin access: https://6dd90eea1a8e2a0fc4db3ee65e365b93-2-4-develop.instances.magento-community.engineering/admin_06e0 Login: b0960393 Password: 87c2fcf1119a
Hello @ia-gaurav,
We have checked this issue on the cloud instance, but we are unable to reproduce the issue. The issue you mentioned in the description is not visible on both desktop and mobile reports.
Please let us know if we have missed anything in order to reproduce the issue.
Thanks
Added solution fix in above link in my comment https://github.com/magento/magento2/pull/34162
@engcom-Hotel You may not notice this line At categories Performance
@magento give me 2.4-develop instance
Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.
Hi @engcom-Hotel, here is your Magento Instance: https://6dd90eea1a8e2a0fc4db3ee65e365b93-2-4-develop.instances.magento-community.engineering Admin access: https://6dd90eea1a8e2a0fc4db3ee65e365b93-2-4-develop.instances.magento-community.engineering/admin_f5b1 Login: 92acc59b Password: ce8ac2d7e586
@magento give me 2.4.3 instance
Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.
Hi @engcom-Hotel, here is your Magento Instance: https://6dd90eea1a8e2a0fc4db3ee65e365b93-2-4-3.instances.magento-community.engineering Admin access: https://6dd90eea1a8e2a0fc4db3ee65e365b93-2-4-3.instances.magento-community.engineering/admin_39de Login: ba683289 Password: 44f6f42754f1
Hello @mrtuvn,
Thanks for the updates!
I was checking the homepage, the issue is not visible there but inner page the issue can be reproducible. Please have a look at to below screenshot:
@ia-gaurav Since the issue is reproducible, we are confirming this issue.
Thanks
:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-1541 is successfully created for this GitHub issue.
:white_check_mark: Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
:x: You don't have permission to export this issue.
@engcom-Hotel: now that you have confirmed this, could you edit your post with those super large images and remove them? Those large images cause issues in our browsers while scrolling through this issue due to taking up a lot of resources while trying to display them. Much appreciated, thanks!
Of course, you always start from Luma, but I think there will be problems with the adaptation of a shop at the latest. Here is an example from my current dev environment.
Preconditions :
Magento 2.4 latest version
Steps 1: Check you site via google page speed :https://developers.google.com/speed/pagespeed/insights Steps 2: Check audit report you will see below issues Does not use passive listeners to improve scrolling performance Consider marking your touch and wheel event listeners as
passive
to improve your page's scroll performance. Learn more. Source …en_US/jquery.min.js:313:558Can it be fixed are it is causing issue with mobile perfomace