Add pagination to attribute Management in admin panel.

jakwinkler commented 3 years ago

Description (*)

There is no pagination when editing attributes in Magento 2 admin panel. When you have 50-100 options, it is manageable, but if your customer is running a large multistore installation, it becomes hard to manage attribute options as it takes forever to load and there is no browser available on the web which would handle 10000 attribute options for 10 multi-stores, which becomes a grid of 100 000 options you have to manually edit... and good luck with it :-)

Expected behavior (*)

styling change will be required because over 10 stores makes columns small and unreadable

Benefits

easier attribute management
less resources needed to load the page
no 503 / 500 errors due to timeouts / memory issues

Additional information

I've already completed such module here: https://github.com/enanobots/m2-attribute-pagination might work on pull-request in few weeks

m2-assistant[bot] commented 3 years ago

Hi @qsolutions-pl. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 3 years ago

Hi @krishprakash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

github-jira-sync-bot commented 3 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-1327 is successfully created for this GitHub issue.

m2-assistant[bot] commented 3 years ago

:white_check_mark: Confirmed by @krishprakash. Thank you for verifying the issue.
Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Aditya-Prakash-Talluru commented 1 year ago

@magento I am working on this

jakwinkler commented 1 year ago

I've created a module for this already: https://packagist.org/packages/enanobots/m2-attribute-pagination

Aditya-Prakash-Talluru commented 1 year ago

@qsolutions-pl I've tried installing the package and pagination is working fine. Shall we proceed with this as PR?

jakwinkler commented 1 year ago

PR won't be accepted as the module does not have any tests (Unit / Integration / MFTF) so it will never by accepted by the CORE team.

Aditya-Prakash-Talluru commented 1 year ago

Are you going to write unit test for the module?

jakwinkler commented 1 year ago

No

magento / magento2