Creditmemo not possible if Total Amount was 0

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.48k stars 9.29k forks source link

Creditmemo not possible if Total Amount was 0 #34294

Closed chequille closed 2 years ago

chequille commented 2 years ago

Preconditions (*)

Magento Version 2.4.3

Steps to reproduce (*)

Create a discount rule with 100%
Enable free shipping
Place an order with the discount and choose free shipping
Total amount is 0
Create Shipping and Invoice
Order is going to status closed
Creditmemo is not possible

Expected result (*)

Even if there was a 100% discount on the order, it should be possible to create a creditmemo, as the customer does have the right to give back to product. It must be possible to get back the product and having the creditmemo on the invoice

Actual result (*)

Order is going to status closed and creditmemo is not possibe anymore

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Hotel commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Hotel commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

slavvka commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Hotel commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel, here is your Magento Instance: https://4cbacf09b833ea61deb174bd6edf54e4.instances.magento-community.engineering Admin access: https://4cbacf09b833ea61deb174bd6edf54e4.instances.magento-community.engineering/admin_1b9a Login: cd3b3cd5 Password: 4afc8b37275e

m2-assistant[bot] commented 2 years ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-November commented 2 years ago

Verified the issue on Magento 2.4-develop branch but cannot able to reproduce the issue due to below issue: https://github.com/magento/magento2/issues/35162. Unable to place order with above configuration as order amount is always becoming negative value. Steps performed: Create Cart Price Rule with Action "Fixed amount discount for Whole Cart" and amount $100 Stores - Settings - Configuration - Sales - Tax - Calculation Settings - 'Apply Customer Tax' Set to "After Discount", Apply 'Discount On Prices' - "Including Tax" - Save Config Default Tax Destination Calculation - Germany Stores - Settings - Configuration - Sales - Shipping Methods - Enable Free Shipping Created 2 tax rules - Germany 19% and 7% with 2 different tax classes Reindex and clear cache Create Products assigned to 2 different tax classes - whole cart value is < 100 . (Ex: Created product with amount $17.40. assigned to 19% tax rate) Front-end Login as Customer - Add Product to Cart Ship to Germany Address, Apply Discount - Payment Step

engcom-November commented 2 years ago

We are moving this ticket to on hold as this is dependent on https://github.com/magento/magento2/issues/35162 to reproduce. This needs to be verified once #35162 is fixed.

engcom-Hotel commented 2 years ago

Hello @engcom-November,

I can see the JIRA related to #35162 has been done. You can continue with this ticket.

Thanks

engcom-November commented 2 years ago

Related JIRA of https://github.com/magento/magento2/issues/35162 was closed as not a bug due to incorrect tax configuration from admin which is applicable to this issue as well. We cannot reproduce this issue without this particular tax configuration. For all other valid tax combinations this issue is not reproducible.

engcom-November commented 2 years ago

We are closing this issue as this behavior is observed only for invalid tax settings calculations and a particular tax rules applied. Reason: During configuring, there is sufficient warning to the merchant that they are performing some configurations that could lead to problems. Being even more stringent and stopping the merchant from proceeding with their configuration would require substantial effort on definition and also implementation. We would probably have to check all prices in the catalogue to check if the minimum price was less than the total cart discount and also the combinations of the discount calculations including or not tax, as well as the tax calculations taking place after discount applied. Altogether, quite a complex scenario for what appears to be somewhat of an edge case caused by trying to configure the store incorrectly.

For all other valid combinations, this issue is not reproducible.

chequille commented 2 years ago

That leaves me speechless now. To say that the shop is configured incorrectly is simply not the truth. In my opinion, no one understands the problem and cannot configure the shop in their test environment the way my shop is configured. Nothing I do with the tax classes is wrong or is declared as incorrect in any way by Magento.

The fact is that there have always been problems with the calculation of tax and discounts. You only need to look at the tickets when searching for "tax".

Maybe some other users here will come forward who share the same opinion and might have the same problem.

Again, sorry for saying this, the shop is not designed for the EU and especially not for Germany, as there are simply other laws that are not taken into account in Magento.

simonmaass commented 2 years ago

Also running magento in Germany and absolutely agree @chequille