magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.55k stars 9.32k forks source link

[Issue] Reduce async console logger #34385

Open m2-assistant[bot] opened 3 years ago

m2-assistant[bot] commented 3 years ago

This issue is automatically created based on existing pull request: magento/magento2#33850: Reduce async console logger


Description (*)

Draft test path https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Ui/view/base/web/js/lib/logger/console-logger.js Out of curiousity do we actually need log always load at all page? Should have config allow we on/off load this or exclude it in production ?

Before this changes Home 187/219 js requests Category 190/223 js requests Details 209/250 js requests Checkout 317/389 js requests

After this changes Home 178/215 js requests Category 181/225 js requests Details 200/247 js requests Checkout 308/379 js requests

we no longer load around ~10 files. The best scenario not errors we have no longer load additional 10 files. But the worse case. When we got something goes wrong, we need log to indicate what problem and where it happen Functionals works without affected

No new update since 2017

cc: @VladimirZaets Can you give me some explain or related docs for this. Thanks you

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

m2-assistant[bot] commented 4 months ago

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Hotel commented 4 months ago

Hello @mrtuvn,

I can see the related pull request is still in draft status. Are you still working on it? And also can you please help us with the steps to reproduce this issue?

Thanks