search

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.55k stars 9.32k forks source link

Standardisation of JavaScript libraries and integration of necessary functions also for the later creation of a theme #34595

Open in-session opened 3 years ago

in-session commented 3 years ago

I would now like to raise a fundamental question: Would it not make sense to better standardise the modules in the future? Perhaps the community could also be involved a little more in the development or survey.

As a small example for the slides: Pagebuilder uses slick slider, 50% per module developer use owl or swiper.

I therefore ask myself why, in this case, one doesn't decide in favour of the Swiper, for example. I, for example, also build everything using swiper, as it has the best functions, requirements and adaptability for me. To be honest, this is always the problem that everything has to be rewritten and that simply costs a lot of time. And even if you are more involved with Magento, it would be very good to have a script template catalogue here. Then the module builders would also stick more to the internal things and build on them. Of course, Magento Luma is supposed to be a lightweight template, but in my opinion it doesn't make sense to use a library that no one will need afterwards. Why owl is used by module developers is mostly due to the customisability of slick slider.

References: https://npmcharts.com/compare/slick,swiper,owl.carousel?interval=360 https://github.com/kenwheeler/slick https://github.com/OwlCarousel2/OwlCarousel2 https://github.com/nolimits4web/swiper

Swiper is also possible for

It is also not dependent on jquery unlike slickslider, which simplifies the subsequent design.

Related Lazyload: https://github.com/magento/magento2/issues/34596

m2-assistant[bot] commented 3 years ago

Hi @in-session. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

ihor-sviziev commented 3 years ago

Hi @sidolov @xmav @kandy, Could you take a look on this feature request? What do you think about it?

sidolov commented 2 years ago

@ihor-sviziev it's a good idea, I believe the case when we are using different libs in different places is happening because we are using some lib during the development and in 5-10 years we are building the new software and new better libs is came up and it's costly to refactor the old one. But the proposal is totally makes sense.