magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.56k stars 9.32k forks source link

Add fixes to make `phpgt/dom` composer dependency compatible with PHP 8.1 #34632

Closed andrewbess closed 2 years ago

andrewbess commented 3 years ago

Description (*)

Some problems have been found in phpgt/dom composer dependency during work on the adding a compatibility Magento with PHP 8.1. We need to deliver our changes to extension repository via making PR there. Finally, we need to create new issue and update composer dependency in the https://github.com/andrewbess/magento2-page-builder

m2-assistant[bot] commented 3 years ago

Hi @andrewbess. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

andrewbess commented 3 years ago

The pull request with fixes have been created - https://github.com/PhpGt/Dom/pull/302

m2-assistant[bot] commented 3 years ago

Hi @andrewbess. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down: