Open m2-assistant[bot] opened 2 years ago
Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).Details
If the issue has a valid description, the label Issue: Format is valid
will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid
appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description
label to the issue by yourself.
[ ] 3. Add Component: XXXXX
label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop
branchDetails
- Add the comment @magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop
branch, please, add the label Reproduced on 2.4.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed
once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.
HI @pykettk,
Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop instance and it is not a bug.It is an Improvement.
Hence we are considering this as a Feature Request.
Thanks.
:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-13239 is successfully created for this GitHub issue.
:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
After having internal discussion, this issue has been marked as feature request and we need a PO confirmation for it so moving it on hold for now.
This issue is automatically created based on existing pull request: magento/magento2#34803: Improve Bundle Option & Selection Data Extensibility
Description (*)
Updated the visibility from
private
topublic
for the following functions inMagento\Bundle\Block\Catalog\Product\View\Type\Bundle
for improved extensibiility:getOptionItemData()
getSelectionItemData()
Manual testing scenarios (*)
etc/di.xml
Questions or comments
I don't know why these were originally declared
private
functions so if there's a reason this change cannot be made, please let me know.Contribution checklist (*)