magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.58k stars 9.32k forks source link

[Issue] Improve Bundle Option & Selection Data Extensibility #34805

Open m2-assistant[bot] opened 2 years ago

m2-assistant[bot] commented 2 years ago

This issue is automatically created based on existing pull request: magento/magento2#34803: Improve Bundle Option & Selection Data Extensibility


Description (*)

Updated the visibility from private to public for the following functions in Magento\Bundle\Block\Catalog\Product\View\Type\Bundle for improved extensibiility:

Manual testing scenarios (*)

  1. Create a new local module
  2. Create a before/after/around plugin for each of the aforementioned functions
  3. Configure the plugin in etc/di.xml
  4. Enable the module
  5. Enable and configure Xdebug and add breakpoints in your plugin(s)
  6. Load a bundle product page on the frontend
  7. Ensure the plugin(s) breakpoint(s) are hit

Questions or comments

I don't know why these were originally declared private functions so if there's a reason this change cannot be made, please let me know.

Contribution checklist (*)

m2-assistant[bot] commented 2 years ago

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Bravo commented 1 year ago

HI @pykettk,

Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop instance and it is not a bug.It is an Improvement.

Hence we are considering this as a Feature Request.

Thanks.

github-jira-sync-bot commented 1 month ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-13239 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 month ago

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

engcom-Dash commented 2 days ago

After having internal discussion, this issue has been marked as feature request and we need a PO confirmation for it so moving it on hold for now.