magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.48k stars 9.29k forks source link

Mass actions silently process only a subset of selected products due to max_session_size_admin limitation #34865

Open hnsr opened 2 years ago

hnsr commented 2 years ago

Preconditions (*)

  1. Magento 2.4.3
  2. Catalog size of ~18k products (I estimate this issue will occur starting at around 10k products)

Steps to reproduce (*)

  1. From the product grid, 'Select All' products
  2. From the Actions drop-down, select 'Update Attributes'
  3. Change any attribute (this step is technically not needed, the error is triggered at the above step when IDs are submitted)

Expected result (*)

  1. All products are processed

Actual result (*)

  1. Only subset of the selected products are processed
  2. When examining the message on the queue, it shows only a few product SKUs
  3. When examining the system.log file, a log entry such as [2021-12-22 12:41:14] main.WARNING: Session size of 498864 exceeded allowed session max size of 256000. appears when submitting the chosen mass-action

Everything works as expected when the max_session_size_admin setting is increased to an appropriate value, but I feel this should be handled a bit more graciously, or perhaps the selected IDs should be passed through the request body instead of the admin session.

The docs do mention that an error is meant to be shown to the user when the limit is exceeded (see https://docs.magento.com/user-guide/stores/security-session-management.html#admin-session) but that does not appear to happen in this case. (I would argue that the error mentioned in the documentation is not particularly helpful either)


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

m2-assistant[bot] commented 2 years ago

Hi @hnsr. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 2 years ago

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Hotel commented 2 years ago

Hi @hnsr, Thank you for reporting the issue. We have tried this issue on Magento 2.4-develop and we have successfully reproduced it.

Steps followed to reproduce issue:

  1. Installed the clean Magento 2.4-dev

  2. Created 20000 plus products.

  3. From the product grid, 'Select All' products

  4. From the Actions drop-down, select 'Update Attributes'

  5. Try to change any attribute and observe the error message.

  6. On the admin panel, Magento shows the error message - “Please select products for attributes update.” (See the attached screenshots) image image

  7. Observe the error logs - “[2021-12-23T13:01:20.142748+00:00] main.WARNING: Session size of 847601 exceeded allowed session max size of 256000.”

The error message that appears in the admin panel is irrelevant and difficult to understand the actual issue also it is not as per the Magento documentation. Hence confirming the issue.

Thanks.

github-jira-sync-bot commented 2 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-2045 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 years ago

:white_check_mark: Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

hnsr commented 2 years ago

Hi @engcom-Hotel , thanks for confirming!