magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.56k stars 9.32k forks source link

Close button not working in a mobile device on product image zoom popup. #34886

Open paresh6002 opened 2 years ago

paresh6002 commented 2 years ago

Preconditions (*)

  1. Magento 2.4.3-p1

Steps to reproduce (*)

  1. Open product page on a mobile device
  2. Scroll product page on mobile
  3. Click on a product image then zoom popup open
  4. Then try to close the popup by clicking the close button
  5. Popup can't be close.

    Description (*)

    I found issue https://github.com/artpolikarpov/fotorama/issues/529 on fotorama git repo. so It is related to each other. all events get passive listener to by using this code.

el.addEventListener ? el.addEventListener(e, fn, {passive: true}) : el.attachEvent('on' + e, fn);

File path: lib/web/fotorama/fotorama.js Line No: 1143

I found this pull request https://github.com/artpolikarpov/fotorama/pull/574

Expected result (*)

  1. Image zoom popup should be closed by clicking on the close button

Screenshot-3-zoom

Actual result (*)

As per analysis, there are 3 issues happening when you zoom-in and zoom-out any product image:

  1. If you click on the product and close it again, mini cart will open itself like below:
Screenshot 2022-01-07 at 12 34 24 PM
  1. If you again click on the product and close it again, search bar will open itself like below:
Screenshot 2022-01-07 at 12 38 00 PM
  1. If you go a little bit down from the product image and then click on product to zoom-in and then try to close it, the product will be not be able to close and user needs to be refresh the page.

Screenshot-from-2021-12-27-12-44-45-png-1920×1080-

Example

https://user-images.githubusercontent.com/59193951/147908020-89d163bb-646b-4a87-bbe2-93499e8a7460.mp4

Related issue: https://github.com/magento/magento2/issues/33855

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

m2-assistant[bot] commented 2 years ago

Hi @paresh6002. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 2 years ago

Hi @engcom-Echo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:


engcom-Echo commented 2 years ago

Hi @paresh6002,

Thank you for reporting the issue.

However, I am not able to reproduce the same. I have tried on multiple fresh 2.4-develop instances but the zoomed up product image on detail page is getting closed properly. The close button action is not getting affected by the console error and I think that console error is already being addressed by our team somewhere. Some screenshots attached of my trials.

Screenshot 2021-12-28 at 1 12 46 PM Screenshot 2021-12-28 at 1 11 42 PM

So, based on it please update below queries:

  1. Can you please check if this issue is reproducible on Magento 2.4-develop instance ?
  2. Let me know if you did anything differently then specified in 'Steps to reproduce', maybe this behaviour is happening after some action ?

Thanks

paresh6002 commented 2 years ago

Hi @engcom-Echo I have added a video for this issue. so you can try to reproduce this issue by scrolling as shown in the video. the issue is in the mobile devices.

Thank You

engcom-Echo commented 2 years ago

Hi @paresh6002,

Thank you for providing the video.

Since you are checking on your website, it could be happening due to some other error which you may have been getting after deployment. You can check logs and see if you find anything.

For confirmation, you can also check on fresh Magento installation or Magento 2.4-develop instance. I have checked again, even on Magento 2.4.3-p1 but this functionality seems to be working fine. Please check attached video for your ref.

https://user-images.githubusercontent.com/51681435/147805223-ef7ce8a9-ca9c-4ff5-a336-16db3492a7ad.mov

Can you please check on fresh installation and let me know if you still face this issue and if yes, please update description with some more info ?

Thanks

paresh6002 commented 2 years ago

Hi @engcom-Echo I have reproduced the issue on fresh Magento installation for Magento 2.4-develop instance. I have attached a new video here. so you can follow the same step as the attached video. And I can see the issue in your video. the search bar/mini-cart will get open when you close the popup. That should not open while closing the image popup.

https://user-images.githubusercontent.com/59193951/147908020-89d163bb-646b-4a87-bbe2-93499e8a7460.mp4

engcom-Echo commented 2 years ago

Hi @paresh6002,

Thank you for providing the video.

I understood when the issue is happening. Verified the issue and is reproducible on Magento 2.4-develop.

As per analysis, there are 3 issues happening when you zoom-in and zoom-out any product image:

  1. If you click on the product and close it again, mini cart will open itself like below:
Screenshot 2022-01-07 at 12 34 24 PM
  1. If you again click on the product and close it again, search bar will open itself like below:
Screenshot 2022-01-07 at 12 38 00 PM
  1. If you go a little bit down from the product image and then click on product to zoom-in and then try to close it, the product will be not be able to close and user needs to be refresh the page.

All issues are reproduced exactly shown in the video by Reporter. Therefore confirming the issue.

Thanks

github-jira-sync-bot commented 2 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-2075 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 years ago

:white_check_mark: Confirmed by @engcom-Echo. Thank you for verifying the issue.
Issue Available: @engcom-Echo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Melnychuk-Alexandr commented 2 years ago

@magento I am working on this

Gorebane commented 2 years ago

Thanks! I had the same issue on Magento 2.4.3-p2, your fix saved me fixing this issue for the client! I approve :) This works.

Davi-Lobo commented 2 months ago

@Melnychuk-Alexandr was this fixed?

engcom-Bravo commented 4 weeks ago

Hi @paresh6002,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is still reproducible.kindly refer the screenshots.

Screenshot 2024-10-16 at 11 43 08 Screenshot 2024-10-16 at 11 43 14

Hence Confirming the issue.

Thanks.

github-jira-sync-bot commented 4 weeks ago

:x: Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-2075