magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.55k stars 9.32k forks source link

Invoices, shipments and credit memos not filtered according to admin timezone #34956

Closed atIOCrON closed 2 months ago

atIOCrON commented 2 years ago

Preconditions (*)

  1. Magento v2.4.3-p1
  2. PHP Version: 7.3.33

Steps to reproduce (*)

  1. Stores > Configuration > Locale Options: Timezone - set the timezone to your local timezone
  2. Clear the cache
  3. Sales > Invoices OR Sales > Shipments OR Sales > Credit Memos
  4. Filter by date

Expected result (*)

  1. The results that are displayed match the admin timezone

Actual result (*)

  1. The results that are displayed are in UTC time

This same issue was patched for the Sales > Orders grid already:

https://support.magento.com/hc/en-us/articles/4403024155917-MDVA-34330-Orders-not-filtered-according-to-admin-timezone

However, the same issue still persists for invoices, shipments and credit memos.

Severity: S1 - Affects critical data or functionality and forces users to employ a workaround

m2-assistant[bot] commented 2 years ago

Hi @atIOCrON. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 2 years ago

Hi @engcom-Echo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:


engcom-Echo commented 2 years ago

Hi @atIOCrON,

Thank you for reporting the issue.

We have tried this issue on Magento 2.4-dev/2.4.3-P1 and we have successfully reproduced it.

Steps followed to reproduce issue:

  1. Installed the clean Magento 2.4-dev/2.4.3-P1
  2. Setup timezone to Magento Default, Created orders and invoices.
  3. Updated timezone to (Australia/Sydney), created new order and invoice.
  4. Filtered the invoices by using the invoice date and observed the result.
  5. The invoice date filter is not filtering data as per the new time zone. (See the attached screenshots)
1 - Screenshot 2022-01-12 at 7 13 12 PM 2 - Screenshot 2022-01-12 at 7 13 48 PM 3 - Screenshot 2022-01-12 at 7 14 11 PM 4 - Screenshot 2022-01-12 at 7 23 26 PM 5 - Screenshot 2022-01-12 at 7 23 44 PM

The invoice date filter on the Invoices page is not working as expected. Hence confirming the issue.

Thanks

github-jira-sync-bot commented 2 years ago

:x: Something went wrong. Cannot create Jira issue.

github-jira-sync-bot commented 2 years ago

:x: Something went wrong. Cannot create Jira issue.

github-jira-sync-bot commented 2 years ago

:x: Something went wrong. Cannot create Jira issue.

github-jira-sync-bot commented 2 years ago

:x: Something went wrong. Cannot create Jira issue.

github-jira-sync-bot commented 2 years ago

:x: Something went wrong. Cannot create Jira issue.

github-jira-sync-bot commented 2 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-2115 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 years ago

:white_check_mark: Confirmed by @sdzhepa. Thank you for verifying the issue.
Issue Available: @sdzhepa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

tuanpht commented 2 years ago

Related to https://github.com/magento/magento2/issues/30214

tuanpht commented 2 years ago

This same issue was patched for the Sales > Orders grid already:

https://support.magento.com/hc/en-us/articles/4403024155917-MDVA-34330-Orders-not-filtered-according-to-admin-timezone

Related commit https://github.com/magento/magento2/commit/77e1e2beacbcd03da2fe612ccfdb6c0c23e00951

atIOCrON commented 2 years ago

Is there any update on this issue? Is it going to be fixed?

atIOCrON commented 2 years ago

Any update on this? When will it be fixed?

atIOCrON commented 1 year ago

Hi @engcom-Echo , Is anyone working on a fix for this issue?

I can see it is tagged dev in progress but if no one is actually working on it can you remove that tag so someone else will see it and pick it up?

atIOCrON commented 3 months ago

Hi @engcom-Echo Are you working on this issue? It's been 2 years, please remove yourself if you're not working on it.

engcom-Bravo commented 2 months ago

@tuanpht Thanks for your contribution!!.

As per this comment https://github.com/magento/magento2/issues/34956#issuecomment-1016399330 we are closing this issue since issue has been fixed.

Thanks.