Can't create label for existing shipment

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.56k stars 9.32k forks source link

Can't create label for existing shipment #34964

Closed alinalexandru closed 1 year ago

alinalexandru commented 2 years ago

Preconditions (*)

Have at least one online carrier configured

Steps to reproduce (*)

Create a shipment without selecting the Create Shipping Label checkbox.
Try to create a shipping label after the shipment is created.

Expected result (*)

In the pop-up you should be capable to distribute the items to packages

Actual result (*)

Even though the ajax (GetShippingItemsGrid) requests returns the order items, no products are displayed in the pop-up.

The issue seems to be in Magento/Shipping/view/adminhtml/web/order/packaging.js in processPackagePrepare function, where the quantity is retrieved from input text. When there is a shipment, the input text does not exits.

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 2 years ago

Hi @alinalexandru. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Nazar65 commented 2 years ago

@magento give me 2.4-develop instanc

Nazar65 commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @Nazar65. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @Nazar65, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

m2-assistant[bot] commented 2 years ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-November commented 2 years ago

Verified the issue on Magento 2.4-develop branch and the issue is reproducible: Steps performed: Created Order using UPS Shipping method and money Order payment Admin - Sales - Orders - View Order - Created Invoice Created Shipment without selecting Shipping Label checkbox Shipments - View shipment - Create Shipping Label Issue: Unable to Add products or unable to save the details. Save button is disabled

github-jira-sync-bot commented 2 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-2111 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 years ago

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

alinalexandru commented 2 years ago

The bug was introduced in 2.4.2 with this PR https://github.com/magento/magento2/pull/27672

razvanazo-cmd commented 2 years ago

I can confirm that @johnulecan PR #34968 works and is not breaking PR #27672

glo05363 commented 1 year ago

@alinalexandru while analysing the issue with given steps we have following observations:

Preconditions:

created one order using fedex carrier with two prosucts.
created shipment without shipment lable.
Once shipment is created , generated shipment label .

Results:

when go to create label after creating shipment , we see the below screen and we are very well allowed to add packages and the products.

in above screen we have added two packages and one product in each package.

Moreover while adding these products the quantities though are editable but we do not have the avenue to enter wrong quantity data that does not match the shipment, meaning it looks good with the quantity information as well.
The shipment page where we show the quantity information is also looking good with the exact information.

As per our analysis everything is working as expected and the proposed changes under #34968 would do no effect except adding the quantity as a hidden value.

Please let us know further on this based on our explanation as what are you trying to achieve as the process looks good.

m2-assistant[bot] commented 1 year ago

Hi @engcom-November. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
1. Verify that the issue is reproducible on 2.4-develop branch
  Details
  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
1. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

engcom-November commented 1 year ago

Hi @alinalexandru , As mentioned in the comment, this issue is no more reproducible on 2.4-develop instance. User is able to select the product products to package and save the shipment. We are able to create Shipping label for existing shipment. Kindly recheck the issue on Magento 2.4-develop instance and let us know if you are still facing any issues. Thank you.

engcom-November commented 1 year ago

Hi @alinalexandru , We are closing this issue as there has been no latest update on the same. Kindly reopen / create new issue if you are still facing any issues. Thank you.