magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.54k stars 9.32k forks source link

Cannot Upload SVG Logo #35125

Closed Stoyvo closed 1 month ago

Stoyvo commented 2 years ago

Preconditions (*)

  1. Read official Magento Documentation (https://docs.magento.com/user-guide/design/logo-upload.html)
  2. Have SVG image

Steps to reproduce (*)

  1. In Admin, Navigate to Content -> Theme Configuration -> Select Theme
  2. Open Header section
  3. Select .svg image for Logo

Expected result (*)

  1. Upload image as SVG

Actual result (*)

Error: "We don't recognize or support this file extension type."


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

m2-assistant[bot] commented 2 years ago

Hi @Stoyvo. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Stoyvo commented 2 years ago

Upon research, I have identified that Magento removed SVG support in 2017? https://github.com/magento/magento2/issues/12451

I find this hard to believe, otherwise official documentation would have been updated right? Official documentation specifically instructs user to select SVG file.

In addition, SVG is the preferred image format for scaling images in web best practices.

m2-assistant[bot] commented 2 years ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

github-jira-sync-bot commented 2 years ago

:x: Something went wrong. Cannot create Jira issue.

github-jira-sync-bot commented 2 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-2438 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 years ago

:white_check_mark: Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

engcom-Delta commented 2 years ago

Hi @Stoyvo , Thank you for reporting the issue. We have verified the issue on Magento 2.4-develop branch and the issue is reproducible. Based on the above observation, confirming the issue.

Steps Performed:

1.Install a clean version of Magento version 2.4-develop 2.Go to – Content>Configuration>Edit(Any configuration)>Header>Upload>Select .svg file Actual result : "We don't recognise or support this file extension type."

image

Expected result : Upload image as SVG successfully .

pranav7870 commented 2 years ago

@magento I am working on this

seak6adtn59v commented 1 year ago

Any progress on this further?

MagestyApps commented 7 months ago

As you can see in the official docs, in default Magento you can upload only PNG, GIF or JPG images for logo. In order to upload an SVG you have to either add a customisation or use a 3rd part solution like this one: https://github.com/MagestyApps/module-web-images

engcom-Bravo commented 1 month ago

@MagestyApps Thanks for your contribution!!.

As per the Magento documentation it supports only PNG, GIF or JPG images for logo and it is an expected behaviour.Hence we are closing this issue.

Thanks.

sprankhub commented 1 month ago

@engcom-Bravo, it is 2024. SVGs should absolutely be supported by now, no matter what the documentation says. I am happy to create a PR for the docs as soon as SVGs are supported ;)