Cannot translate meta descriptions added via XML instructions.

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.5k stars 9.3k forks source link

Cannot translate meta descriptions added via XML instructions. #35191

Open ioweb-gr opened 2 years ago

ioweb-gr commented 2 years ago

Preconditions (*)

2.4.3-p1
A custom controller
A custom layout.xml with a meta description content
2 store views

Steps to reproduce (*)

In your layout.xml add a meta description like this

<meta name="description" content="my english content" translate="content" />

In your i18n/el_GR file for example add a translation for the content.

Incidentally I've tried adding the description like this

<meta name="description" content="my english content" translate="true"/>
<meta name="description" content="my english content" />

Neither way seems to work to make it translateable.

However the phrase is properly collected using i18n:collect-phrases

Expected result (*)

1.The content is translated

Actual result (*)

The content is not translated

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 2 years ago

Hi @ioweb-gr. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 2 years ago

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  Details
  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
1. Verify that the issue is reproducible on 2.4-develop branch
  Details
  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

Join Magento Community Engineering Slack and ask your questions in #github channel.

engcom-Dash commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Dash, here is your Magento Instance: https://28a1987dfc30981e1b420c7e7b6c0ee0.instances.magento-community.engineering Admin access: https://28a1987dfc30981e1b420c7e7b6c0ee0.instances.magento-community.engineering/admin_67b2 Login: 992f7a73 Password: 4b80d197a259

engcom-Dash commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Dash, here is your Magento Instance: https://28a1987dfc30981e1b420c7e7b6c0ee0.instances.magento-community.engineering Admin access: https://28a1987dfc30981e1b420c7e7b6c0ee0.instances.magento-community.engineering/admin_c666 Login: 52f053e0 Password: 6d463ebb416f

m2-assistant[bot] commented 2 years ago

Hi @engcom-Charlie. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Charlie commented 2 years ago

Hi @ioweb-gr,

In order to reproduce the issue, can you please guide me on below points.

Have you missed to add something after “Incidentally I've tried adding the description like this” in your comment?
Can you please provide some detailed information in order to investigate it further. Eg. Are you trying to see the translated content from i18n/el_GR for the added tag in .xml file? Or kindly provide all steps to reproduce in order to investigate this issue further.

Thank you in advance!

ioweb-gr commented 2 years ago

Hi, it seems github treated the text as tags so they wouldn't appear. I've added the content that was missing in codeblock.

It seems the translate=true tag is not allowed for the above mentioned tags.

engcom-Charlie commented 2 years ago

:heavy_check_mark: Issue Confirmed

Tried to reproduce the issue on magento 2.4-develop and its reproducible.

Manual testing scenario:

Created one custom module
In order to do translations, we can either install Greek language pack in app/i18n or we can add el_GR.csv file in respective custom modules’s i18n folder. I have tested using both ways.
In layout file(.xml) file added below lines for meta description.

<meta name="description" content="my english content" translate="true"/>

Also tried with below options

<meta name="description" content="my english content" />
<meta name="my_custom_type" content="my english content" translate="true"/>

Change the Locale from Stores >> Settings >> Configuration >> General >> Local Options >> to Greek Note: We can also create 2 different store views and set Greek language for one of the store view.

Expected Result: The content should get translated

Actual Result: Meta tag content is not getting translated.

As per above findings confirming the issue.

github-jira-sync-bot commented 2 years ago

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

github-jira-sync-bot commented 2 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-5940 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 years ago

:white_check_mark: Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.