magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.54k stars 9.32k forks source link

Magento 2.4.4 frontend menu mobile #35329

Closed fmineo closed 1 year ago

fmineo commented 2 years ago

Preconditions (*)

  1. PHP 8.1
  2. Magento 2.4.4 (installed via composer create-project)
  3. No sample-data, all defaults.

Steps to reproduce (*)

  1. Create a category with a subcategory
  2. Go to frontend on mobile device (Vertical mode)

Expected result (*)

  1. We should be able to open submenu categories dropdown through the menu.

Actual result (*)

  1. We can only see the "top-level" categories, and not the subcategories.
  2. If rotate the device in horizontal mode and again in vertical you will able to open the subcategory menu.

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

m2-assistant[bot] commented 2 years ago

Hi @fmineo. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 2 years ago

Hi @ajijshekh123. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

m2-assistant[bot] commented 2 years ago

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Hotel commented 2 years ago

@magento give me 2.4.4 instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Hotel commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

andrewbess commented 2 years ago

@magento give me 2.4.4 instance with env PHP 8.1

magento-deployment-service[bot] commented 2 years ago

Hi @andrewbess. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @andrewbess, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Hotel commented 2 years ago

Hello @fmineo,

Thanks for your report and collaboration!

We have tried to reproduce the issue in Magento 2.4.4 but for us, the issue is not reproducible. Please find attached the below screencast for reference:

https://user-images.githubusercontent.com/51681618/164174602-800d153b-0163-4cba-b938-ee2abb6ea3bf.mov

Let us know in case we have missed anything.

Thanks

fmineo commented 2 years ago

Hello @engcom-Hotel,

Thanks for your support!

As I specified, the device must be in "portrait mode" (held vertically) and not horizontally as you showed in the video.

I am also attaching a video trying to be clearer:

https://user-images.githubusercontent.com/5881339/164190034-8f93a4a3-2240-49a2-9090-2bb464e212ba.mp4

Hope it helps.

Thanks

slavvka commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

slavvka commented 2 years ago

@magento give me test instance

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka. Thank you for your request. Comments like @magento give me test instance are intended for instance deployments on Pull Requests. Please use comment like: @magento give me 2.4-develop instance to request an instance on an issue.

slavvka commented 2 years ago

@magento give me 2.4.4 instance

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

slavvka commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka, here is your Magento Instance: https://a2f056b41f368c1630574a4ca609d88e.instances.magento-community.engineering Admin access: https://a2f056b41f368c1630574a4ca609d88e.instances.magento-community.engineering/admin_871a Login: 2dbda570 Password: 6b180a554389

fmineo commented 2 years ago

The issue also occurs in the Magento Instance above.

engcom-Hotel commented 2 years ago

Hello @fmineo,

Thanks for the report & collaboration!

We have tried again to reproduce the issue in Chrome's device toolbar and in a mobile device. The issue is reproducible for us with the given steps.

Hence confirming this issue.

Thanks

github-jira-sync-bot commented 2 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-2907 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 years ago

:white_check_mark: Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

github-jira-sync-bot commented 2 years ago

:x: You don't have permission to export this issue.

slavvka commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @slavvka, here is your Magento Instance: https://a2f056b41f368c1630574a4ca609d88e.instances.magento-community.engineering Admin access: https://a2f056b41f368c1630574a4ca609d88e.instances.magento-community.engineering/admin_cf40 Login: fa30756c Password: 3ea55b2ca2f7

redati commented 2 years ago

I have the same problem. The submenu disappears in mobile.

dphilipps commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @dphilipps. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @dphilipps, here is your Magento Instance: https://a2f056b41f368c1630574a4ca609d88e.instances.magento-community.engineering Admin access: https://a2f056b41f368c1630574a4ca609d88e.instances.magento-community.engineering/admin_17f3 Login: 32aba880 Password: ff87ec737fdf

dphilipps commented 2 years ago

I have reproduced this on Chrome desktop with dev-tools and require an extra step to reproduce: refresh the page after it has loaded. See the video: https://www.loom.com/share/64ccbe7015d741f8a95720a5ef63afe8

On my Galaxy S9 using Chrome, the menu is broken immediately without the refresh.

dphilipps commented 2 years ago

https://user-images.githubusercontent.com/44231639/166661335-a02c7c3c-4816-4fef-8c3b-62c39c3c5dde.mp4

fmineo commented 2 years ago

@magento I am working on this

m2-assistant[bot] commented 2 years ago

Hi @fmineo! :wave: Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

fmineo commented 2 years ago

@magento add to contributors team

m2-assistant[bot] commented 2 years ago

Hi @fmineo! :wave: Thank you for joining. Please accept team invitation :point_right: here :point_left: and add your comment one more time.

fmineo commented 2 years ago

@magento I am working on this

fmineo commented 2 years ago

@magento I am working on this

MyroslavDobra commented 2 years ago

My workaround Add this._toggleDesktopMode(); to lib/web/mage/menu.js to _init method right before line mediaCheck({

sukeshini-kot commented 2 years ago

Is there any update on this?

barryvdh commented 2 years ago

The workaround in https://github.com/magento/magento2/issues/35329#issuecomment-1139618176 fixes it, thanks!

dphilipps commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @dphilipps. Thank you for your request. I'm working on Magento instance for you.