magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.53k stars 9.31k forks source link

Hover colour not applied on static grids in admin #35358

Open fredden opened 2 years ago

fredden commented 2 years ago

Preconditions

  1. Have more than one admin user
  2. Tested on 2.4.3-p2 and ef0ffcd37470e83337133a167dc4504f86037f28 (ie, current HEAD of 2.4-develop branch)

Steps to reproduce

  1. Navigate to a static grid - for example the admin user grid (System -> Permissions -> All Users)
  2. Notice background colours shown on each row.
  3. Hover over the first row.
  4. Notice background colour of hovered-over row.
  5. Hover over the second row.
  6. Notice background colour of hovered-over row.

Compare this to a dynamic grid where the hover background colour works as expected. (For example, the Design Configuration grid behaves as expected - Content -> Design -> Configuration.)

Expected result

  1. All rows highlight as they are hovered over.
Screen-shots of Admin Users grid working as expected (CSS manipulated on-page) ![Screenshot_2022-04-22_21-56-22](https://user-images.githubusercontent.com/334786/164792320-f99388eb-66b8-4196-8580-32bc2b2e533d.png) ![Screenshot_2022-04-22_21-57-13](https://user-images.githubusercontent.com/334786/164792422-a7ed1eeb-8605-49ae-9992-0138b87fb78b.png)
Screen-shots of Design Configuration grid working as expected ![Screenshot_2022-04-22_21-53-27](https://user-images.githubusercontent.com/334786/164792074-5318cd8c-d193-409b-98ec-f3bc20fd0a22.png) ![Screenshot_2022-04-22_21-53-37](https://user-images.githubusercontent.com/334786/164792089-2d0ec75e-b8e4-4179-95e7-94478c51b8ae.png)

Actual result

  1. Only odd-numbered rows highlight as they are hovered over.
  2. Even-numbered rows do not show any differently when hovered over or not.
Screen-shots of Admin Users grid as it currently behaves ![Screenshot_2022-04-22_21-59-21](https://user-images.githubusercontent.com/334786/164792701-7a232c72-37f7-4d62-9727-8428ce08357b.png) ![Screenshot_2022-04-22_21-59-34](https://user-images.githubusercontent.com/334786/164792718-27025667-1faa-4fec-8caf-52f6ba998529.png)

Technical details

It may help a developer to know that the hover style is here: https://github.com/magento/magento2/blob/610f7f51faa94639da29f8001aded7559f114c54/app/design/adminhtml/Magento/backend/Magento_Ui/web/css/source/module/_data-grid.less#L190-L194

And the alternating-row style is here: https://github.com/magento/magento2/blob/610f7f51faa94639da29f8001aded7559f114c54/app/design/adminhtml/Magento/backend/Magento_Ui/web/css/source/module/data-grid/_data-grid-static.less#L18-L28


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

m2-assistant[bot] commented 2 years ago

Hi @fredden. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 2 years ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-November commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-November. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-November, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-November commented 2 years ago

Verified the issue on Magento 2.4-develop branch and the issue is reproducible. Hovering on odd numbered rows - background color is changing as expected. Hovering on even numbered rows - Background color is not changed. image Issue: image Expected behavior: Behavior should be consistent across all pages (Ex: Content - Design - Configuration) - Hovering all rows - Background color is changing as expected.

github-jira-sync-bot commented 2 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-2916 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 years ago

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

github-jira-sync-bot commented 2 years ago

:x: Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.magento.com/browse/AC-2916

Usik2203 commented 2 years ago

@magento I am working on this