Product page gives error because of url rewrites

[edas11]

Preconditions (*)

1. Magento 2.4.1, 2.4.3 (this problem may exist from 2.3.3).
2. Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization -> Product URL Suffix is empty.
3. Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization -> Category URL Suffix is empty.
4. Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization -> Use Categories Path For Product URLs is Yes.
5. Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization -> Generate "category/product" URL Rewrites is No.
6. There is a category Test Category created under root category and Test Sub Category created under Test Category. There is a product Test and it is assigned to Test Sub Category. This is to make category url path have the product url path in it preceded by a forward slash (/). In this example the product url path is "test" and Test Sub Category url path is "test-category/test-sub-category"

Steps to reproduce (*)

1. Go to Test Sub Category.
2. Click on product Test.

Expected result (*)

1. The product page is loaded successfully.

Actual result (*)

1. There is 404 error (on 2.4.3 or newer version) or 500 error (on older version than 2.4.3).

Looks like on line 173 in \Magento\CatalogUrlRewrite\Model\Storage\DynamicStorage function str_replace should not be used. We fixed it on our installation by changing that line to this:

$categoryPath = substr($requestPath, 0, -1 * strlen('/' . $productUrl));

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [x] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @edas11. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

  :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant[bot]]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• [ ] 5. Add label Issue: Confirmed once verification is complete.

• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-November. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-November, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[engcom-November]

Hi @edas11 , Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop branch but cannot able to reproduce the issue. Note: FYI.. The products in the main menu are determined by the root category that is assigned to the store. (Created new root category should be assigned to the store 1st (Stores - All Stores - Edit Store - Change root category - select new category)) - Save Reindex and clear cache.

Steps performed: Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization -> Product URL Suffix is empty. Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization -> Category URL Suffix is empty. Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization -> Use Categories Path For Product URLs is Yes. Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization -> Generate "category/product" URL Rewrites is No. Created new root category and assigned to store (Catalog - Categories) Created sub category under new root category and save (Catalog - Categories) Created Product and assigned only new sub category and save Front -end - Home - Click on Sub category - Click on Product - No issue. User is redirected to product details page

Kindly recheck the issue on Magento 2.4-develop branch as it is having latest code base and provide missing steps if any if the issue is still reproducible. Thank you.

[edas11]

Hi,

Thanks for looking into this. The categories and product in your test are not correct. First of all, nesting level is wrong. It should be at least 3: Root Category -> Category -> Sub Category. Also, category and product names are wrong. Error only happens if url path of category has product url path in it preceded by a forward slash. This basically means that category name has to have product name at the beginning. For example if product is Shoe category should be Shoes. If you follow category and product names I gave in description error should appear.

[engcom-November]

Thanks for your inputs @edas11 . Verified the issue again on Magento 2.4-develop branch and the issue is reproducible only if category name having product name at the beginning. (Ex: Product name: shoe, category name is shoes or product name is Test and category name is Test sub category) Clicking on Product giving 404 error.

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-2950 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.