magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.3k forks source link

Issue with Ordering from Gift Registry Magento 2.4.4 Enterprise/Commerce #35432

Closed shawkatalam-dev closed 7 months ago

shawkatalam-dev commented 2 years ago

Preconditions (*)

  1. We are using Magento 2.4.4 Enterprise/Commerce Edition with PHP 8.1
  2. MySQL 8.0
  3. Ubuntu 20.04 LTS
  4. nginx 1.18
  5. Trying to place order from registrants gift registry item

Steps to reproduce (*)

  1. Add a product to gift registry
  2. share the gift registry link
  3. open the gift registry link in another browser/incognito window
  4. Add qty and add to cart the item
  5. Go to Checkout Page, select shipping method(As shipping address is already selected, provided by the registrant)
  6. Select the payment Method
  7. Click on Place Order Button

Expected result (*)

  1. The order should get placed and the registrant should get gift registry update email

Actual result (*)

  1. Something went wrong with your request. Please try again later.
  2. In log we can see the error Call to a member function getUpdatedQty() on null in /var/www/html/local.magento244.com/vendor/magento/module-gift-registry/Block/Email/Items.php:61
  3. Screenshot from 2022-05-06 00-33-19

  4. The order is not placed
m2-assistant[bot] commented 2 years ago

Hi @shawkatalam-dev. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 2 years ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Delta commented 2 years ago

Hi @shawkatalam-dev ,

Thank you for logging an issue . We tried to reproduce the issue on 2.4 develop ( Enterprise Edition) Frontend , but need more clarity on step 3 & step 4.

Followed steps:

  1. Add a product to gift registry
Screenshot 2022-05-06 at 7 38 36 PM
  1. share the gift registry link
Screenshot 2022-05-06 at 7 42 21 PM
  1. open the gift registry link in another browser/incognito window

Query : Which link we suppose to use at this movement ? the link that we got in the email ? or the link that present on the frontend?

  1. Add qty and add to cart the item Query: May i have screenshots please?

Hence, request to help me to reproduce the issue.

shawkatalam-dev commented 2 years ago

Hello ,

We are using vanilla Magento instance. Below is the more detailed steps to reproduce the issue.

  1. First add a product to gift registry from cart page

image

  1. Go to your gift registry and click on the share button/link

image

  1. Now add Message , Invitee Details and share the Gift Registry

image

  1. Open the email id and click on the registry location link (Suggest to use another browser or try incognito mode, so that it does not use the current user session)

image

  1. Now add qty and click on Add To Cart

image

  1. After that do the usual checkout process and go to the payment page , select any payment method and click on place order.

expected is the order should be placed, but we are getting error

image

When we checked log we can see the below message

image

Hope this information is useful.

shawkatalam-dev commented 2 years ago

@magento give me 2.4-develop instance. I want to check in vanilla instance as well

magento-deployment-service[bot] commented 2 years ago

Hi @shawkatalam-dev. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @shawkatalam-dev, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

shawkatalam-dev commented 2 years ago

@engcom-Delta waiting for your response

engcom-Delta commented 2 years ago

Hi @shawkatalam-dev ,

Thanks for sharing the details and we have retested it again on Magento Enterprise Edition 2.4 Develop. Issue is reproducible. Hence issue is confirmed.

  1. First add a product to gift registry from cart page

    Screenshot 2022-05-19 at 8 52 29 PM
  2. Go to your gift registry and click on the share button/link

Screenshot 2022-05-19 at 9 01 05 PM
  1. Now add Message , Invitee Details and share the Gift Registry
Screenshot 2022-05-19 at 7 46 53 PM
  1. Open the email id and click on the registry location link (Suggest to use another browser or try incognito mode, so that it does not use the current user session)
Screenshot 2022-05-19 at 8 16 10 PM
  1. Now add qty and click on Add To Cart
Screenshot 2022-05-19 at 8 22 42 PM
  1. After that do the usual checkout process and go to the payment page , select any payment method and click on place order.
  2. Getting the below error .
Screenshot 2022-05-19 at 8 42 16 PM
github-jira-sync-bot commented 2 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-3114 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 years ago

:white_check_mark: Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Pranav-242 commented 2 years ago

@magento i'm working on this.

veloraven commented 9 months ago

Internal Team started working on this issue

m2-assistant[bot] commented 9 months ago

Hi @veloraven. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction: