Please fix the N+1 Query antipattern which significantly slows down cart page when you have Customer Address "custom attributes"

[peteracs]

Preconditions and environment

• Magento version: 2.4.3
• Create at least 3 customer address custom attributes

Steps to reproduce

1. Create 3 new customer address custom attributes
2. Go to checkout page. The performance drops by at least 2 seconds

I did profiling and found the culprit.

vendor/magento/module-customer/Model/Address/CustomAttributesProcessor.php

Line 51

            foreach ($customAttributes as $customAttributeCode => $customAttribute) {
                $attributeOptionLabels = $this->getAttributeLabels($customAttribute, $customAttributeCode);
                if (!empty($attributeOptionLabels)) {
                    $customAttributes[$customAttributeCode]['label'] = implode(', ', $attributeOptionLabels);
                }
            }

As you can see, there is a foreach here, which will go to "getAttributeLabels" and then $this->attributeOptionManager->getItems()' finally vendor/magento/module-eav/Model/Entity/Attribute/OptionManagement.php line 209 $attribute = $this->attributeRepository->get($entityType, $attributeCode);

So if you have 5 attributes, instead of having 1 SQL query, it will have 5 SQL query ... This is huge performance impact on checkout page

Expected result

Fast checkout

Actual result

When a lot of customer address custom attributes exists, the performance significantly drops on checkout page due to a foreach loop that triggers SQL one by one instead of having one SQL for customer address custom attributes

Additional information

No response

Release note

No response

Triage and priority

• [X] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [X] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [X] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [X] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @peteracs. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

  :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant[bot]]

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
     Details

     If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Dash]

Hello @peteracs ,

We have tried to reproduce the issue in Magento 2.4.3 the issue is not reproducible. Please refer the below screenshot for the reference;

We have followed the below steps in order to reproduce the issue: 1.Create 3 new customer address custom attributes 2.Go to checkout page. 3.Order Placed Sucessfully Let us know in case we have missed anything.

Thanks!!!

[peteracs]

@engcom-Dash Did you check the performance before and after the 3 new customer address custom attributes? It was seriously hit.

[engcom-Dash]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-Dash, here is your Magento Instance: https://ded87a9fce5085f9f92804529003b181.instances.magento-community.engineering Admin access: https://ded87a9fce5085f9f92804529003b181.instances.magento-community.engineering/admin_05d0 Login: 32325df9 Password: a3962e56fb58

[engcom-Dash]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-Dash, here is your Magento Instance: https://ded87a9fce5085f9f92804529003b181.instances.magento-community.engineering Admin access: https://ded87a9fce5085f9f92804529003b181.instances.magento-community.engineering/admin_d01b Login: 9ed5a8c4 Password: bc46461183e6

[engcom-Dash]

Hi @peteracs , We are Getting Same Results Like the performance drops occurred. so We are Confirming the Issue. Here i Attached Screenshot For Reference.