AwsS3 PHP8 compatibility issue

Nuranto commented 2 years ago

Preconditions and environment

Magento version 2.4.4
PHP 8.1

Steps to reproduce

I don't know how to reproduce, I find that error in production logs, but without trace.

However, it should be fixed anyway by adding a cast on $path variable, or better : manage the case where $path variable is empty or/and null

Expected result

no error

Actual result

.CRITICAL: TypeError: preg_replace(): Argument #3 ($subject) must be of type array|string, null given in /var/www/html/vendor/magento/module-aws-s3/Driver/AwsS3.php:302

Additional information

Concerned code : Magento\AwsS3\Driver\AwsS3

 public function getRealPathSafety($path)
    {
        //Removing redundant directory separators
        $path = preg_replace(
            '~(?<!:)\/\/+~',
            '/',
            $path
        );

        if (strpos($path, '/.') === false) {
            return $path;
        }

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 2 years ago

Hi @Nuranto. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

simonmaass commented 2 years ago

I can confirm this error on our magento 2.4.4 and php 8.1 instance. This error occurs when trying to upload an image in the product description:

In the system logs i can see the following error:

[2022-07-06T16:04:32.635581+00:00] .CRITICAL: TypeError: preg_replace(): Argument #3 ($subject) must be of type array|string, null given in /vendor/magento/module-aws-s3/Driver/AwsS3.php:302
Stack trace:

m2-assistant[bot] commented 2 years ago

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Hotel commented 2 years ago

Hello @Nuranto @simonmaass,

Thanks for the report and collaboration!

We have tried to reproduce the issue in Magento 2.4-develop instance but the issue is not reproducible for us. We are able to upload the image while adding a product description. Please refer to the below screenshot:

For AWS S3 is enabled. Please let us know in case we have missed anything.

Thanks

engcom-Hotel commented 2 years ago

Dear @Nuranto @simonmaass,

We have noticed that this issue has not been updated for a period of 14 Days. Hence we assume that this issue is fixed now, so we are closing it. Please raise a fresh ticket or reopen this ticket if you need more assistance on this.

Regards

magento / magento2