[ja_jp] language package is not installable

zepgram commented 2 years ago

Preconditions and environment

Magento version 2.4.3-p2 enterprise edition
Composer v2.3.10

Steps to reproduce

Get a magento environment (community/enterprise)
Run composer require community-engineering/language-ja_jp:1.0.19 (any tag, it will be the same result)
Composer will try to install a priority version "1.0.0" that doesn't exist on official repository: https://github.com/magento-l10n/language-ja_JP/tags

Expected result

Ja_JP package is supposed to be installable on any Magento version / edition

Actual result

Composer prompt this issue: _Root composer.json requires community-engineering/language-ja_jp 1.0.19, it is satisfiable by community-engineering/language-ja_jp[1.0.19] from composer repo (https://repo.packagist.org) but community-engineering/language-jajp[1.0.0] from composer repo (https://repo.magento.com) has higher repository priority. The packages from the higher priority repository do not match your constraint and are therefore not installable. That repository is canonical so the lower priority repo's packages are not installable. See https://getcomposer.org/repoprio for details and assistance.

FYI: This issue has been directly reported on the repository in 2021 -> https://github.com/magento-l10n/language-ja_JP/issues/1

Additional information

No response

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 2 years ago

Hi @zepgram. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

HirokazuNishi commented 2 years ago

@zepgram as I commented on l10n repo, please use https://github.com/magentoj/language-ja_JP for 2.4.x .

m2-assistant[bot] commented 2 years ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-November commented 2 years ago

Hi @zepgram , Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop branch but could not reproduce the issue. Also looks like this is not Magento related issue but the issue with 3rd party package: community-engineering/language-ja_jp:1.0.19. and code of this extension is not part of https://github.com/magento/magento2 git repository. All questions, issue reports and fix for them should be addressed to the corresponding extension owners(support) on the Magento Market place page. Fyi.. japanese language package can be installed with mageplaza as well and is working fine on both community-edition and enterprise-edition as well. Please check.

composer require mageplaza/magento-2-japanese-language-pack:dev-master mageplaza/module-smtp 
php bin/magento setup:static-content:deploy ja_JP
php bin/magento indexer:reindex
php bin/magento cache:clean
php bin/magento cache:flush

zepgram commented 2 years ago

The repository is published by https://github.com/magento-l10n (hi :wave: @magento-l10n) with an Adobe address magento-l10n@adobe.com. I don't think this is a marketplace issue: it's a community project.

Installation of the package probably worked for you because you installed Magento with GIT. You may install the project with composer to be able to reproduce.

Steps to reproduce:

composer create-project --repository-url=https://repo.magento.com/ magento/project-community-edition magento-composer
cd magento-composer
composer require community-engineering/language-ja_jp:1.0.19

engcom-November commented 2 years ago

Hi @zepgram , Thank you for the response. This is not part of our Magento repositories. Only all questions, issue reports and fix related to https://github.com/magento/magento2 this git repository should be addressed here in this board. All questions / issue reports related to 3rd party package / extensions should be addressed to the corresponding extension owners(support) Thank you.

engcom-November commented 2 years ago

Hi @zepgram , I verified the issue again on both composer based installation 2.4.4. and 2.4-develop git installation and the issue is reproducible on composer based installation 2.4.4 (project-community-edition) but not on 2.4-develop git installation. So this issue may got fixed and resolved in 2.4-develop branch and it will be available in the next Magento release version. Thank you.

zepgram commented 2 years ago

The issue is totally reproductible if you use composer.

This is related to composer metapackage installation.

If you really want to prove that you are right then, go on branch 2.3-develop from git: if you can install the package then it means there is a composer issue with the metapackage installation.

If you cannot install the package then you are right and it will be solved on next 2.4 release.

-> You can't say it's fine if you install the package through git. You are not installing the real composer metapackage as you are supposed to...

engcom-November commented 2 years ago

Hi @zepgram , We are able to install the package on both 2.3 git instance and 2.4-develop branch as well but cannot install the package on latest composer instance 2.4.4 project-community-edition. Hence we are confirming this issue.

github-jira-sync-bot commented 2 years ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-6317 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 years ago

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

engcom-November commented 2 years ago

Hi @zepgram , We got the confirmation after internal discussions that Adobe Japan maintains https://repo.packagist.org/packages/magentoj/language-ja_jp and https://github.com/magentoj/language-ja_JP Localization packages but not https://github.com/magento-l10n/language-ja_JP. Kindly use the above repositories for ja_JP package installation and reopen / create new issue if you are facing any issues. Thank you.

hostep commented 2 years ago

@engcom-November, Adobe definitely maintains all packages under https://github.com/magento-l10n

It's extremely weird that version 1.0.0 is the only one of community-engineering/language-ja_jp available on repo.magento.com, and all versions that were later created on github are not on repo.magento.com All (?) other language packs under the community-engineering namespace are not published on repo.magento.com, so why did this happen with the Japanese one?

@sidolov, @sdzhepa , can you talk to the internal team to figure this out?

If the official answer is that a mistake was made with the community-engineering/language-ja_jp package and it can't be solved, so that people should use magentoj/language-ja_jp instead, then this needs to be clearly communicated. It should at least be mentioned in the README file of this repo: https://github.com/magento-l10n/language-ja_JP that this package is not the correct one and direct you to the correct one.

zepgram commented 1 year ago

Hi @zepgram , We got the confirmation after internal discussions that Adobe Japan maintains https://repo.packagist.org/packages/magentoj/language-ja_jp and https://github.com/magentoj/language-ja_JP Localization packages but not https://github.com/magento-l10n/language-ja_JP. Kindly use the above repositories for ja_JP package installation and reopen / create new issue if you are facing any issues. Thank you.

@engcom-November magentoj is not the correct namespace, you are offering to us a lazy answer. Come on... please, do your job. You'll feel accompished at the end of the day.

magento / magento2