magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.39k stars 9.29k forks source link

Braintree Paypal ON, CreditCard OFF. Broken checkout. #35961

Open zhartaunik opened 1 year ago

zhartaunik commented 1 year ago

Preconditions and environment

Steps to reproduce

  1. Navigate to Stores / Configuration / Sales / Payment methods / Braintree section
  2. Fulfill all credentials for it and make Enable Card Payments = NO
  3. Navigate to Frontend.
  4. Add any product to the cart.
  5. Go to Checkout.
  6. Try to use PayPal payment method Screenshot from 2022-08-17 12-52-31 .

Expected result

Paymen method should be selected and progress-bar should disappear.

Actual result

Endless progress-bar loading

JS Error in the console adapter.js:66 Uncaught TypeError: Cannot read properties of undefined (reading 'clientToken') at Object.getClientToken (adapter.js:66:66)

Additional information

The issue occurs because of not existing part of configuration which name is 'braintree'. window.checkoutConfig.payment.braintree

This config is passing via the following PHP Class: \PayPal\Braintree\Model\Ui\ConfigProvider::getConfig()

Release note

No response

Triage and priority

m2-assistant[bot] commented 1 year ago

Hi @zhartaunik. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

zhartaunik commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @zhartaunik. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @zhartaunik, here is your Magento Instance: https://b3c368ddfc2f6397201b87d78638b72e.instances.magento-community.engineering Admin access: https://b3c368ddfc2f6397201b87d78638b72e.instances.magento-community.engineering/admin_b0a6 Login: d02bd5aa Password: b59ba9c956c3

m2-assistant[bot] commented 1 year ago

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:


zhartaunik commented 1 year ago

Please help me to understand. There is no Braintree section there. However according to vendor/composer/installed.json

"name": "magento/product-community-edition", "requires": "paypal/module-braintree": "4.4.0", __"required": "paypal/module-braintree-core": "4.4.0",

I assume that it's not complete vanilla Magento version.

engcom-Dash commented 1 year ago

Hi @zhartaunik ,

We are able to reproduce the issue in 2.4.5 magento instance and we are getting actual results like endless progress bar loading and JS error is appeared in console.

Screenshots for reference:

Screenshot from 2022-08-17 16-01-31

Steps to reproduce:

1.Navigate to Stores / Configuration / Sales / Payment methods / Braintree section 2.Fulfill all credentials for it and make Enable Card Payments = NO 3.Navigate to Frontend. 4.Add any product to the cart. 5.Go to Checkout.

We got same error----Like---->JS Error in the console adapter.js:66 Uncaught TypeError: Cannot read properties of undefined (reading 'clientToken')

So we are confirming the issue in 2.4.5 magento instance.

Let us know if we are missing anything

Thanks!!!

github-jira-sync-bot commented 1 year ago

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

github-jira-sync-bot commented 1 year ago

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

github-jira-sync-bot commented 1 year ago

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

Viktorja1 commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @Viktorja1. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @Viktorja1, here is your Magento Instance: https://b3c368ddfc2f6397201b87d78638b72e.instances.magento-community.engineering Admin access: https://b3c368ddfc2f6397201b87d78638b72e.instances.magento-community.engineering/admin_3e95 Login: 9a44f240 Password: 536e109ea2f0

zhartaunik commented 1 year ago

@Viktorja1 I tried to reproduce but this vanilla magento doesn't contain a module braintree. I put the description above that there is a necessary dependency, but by some reason this module is absent.

Viktorja1 commented 1 year ago

@zhartaunik Please try to reproduce this issue on 2.4.5 brunch only

zhartaunik commented 1 year ago

@Viktorja1 in my vision magento from this branch differs from those magento which is installing via composer. It doesn't contain a dependency it must.

github-jira-sync-bot commented 1 year ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-6417 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 year ago

:white_check_mark: Confirmed by @AmyJZhao. Thank you for verifying the issue.
Issue Available: @AmyJZhao, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

friendscottn commented 1 year ago

It looks like there's an example of how to fix this on the older gene/module-braintree, but the fix is not available in the magento marketplace yet.

EXTRA5POWER commented 1 year ago

5388 4105 3200 7731 09/32 CVV 812