When VAT number validation fails by the VIES service, there is no trace about the exception message in the log files

[hostep]

Preconditions and environment

• Magento version: any

Steps to reproduce

Look at the code over here: https://github.com/magento/magento2/blob/2.4.5/app/code/Magento/Customer/Model/Vat.php#L214-L218

1. In the code over here, change the url to https://example.com/taxation_customs/vies/checkVatService.wsdl so we can simulate an unexpected error
2. In the Magento back office, go to Stores > Configuration > General > General > Store Information
3. For the Country field, pick an EU country (like France)
4. For the VAT Number field, enter something random, like 012345
5. Press the Validate VAT Number button
6. Inspect the var/log/exception.log file or system.log file

Expected result

1. Expect that the exception message is logged somewhere, so that when an exception is occurring, it's easy to find the details in a log file

Actual result

1. No exception message is being logged

Additional information

We had a certain shop, where the VAT number validation kept on failing and there was no trace about why it happened, when we tried debugging on our local environment, no issue was found, it only happened on the staging server.

After some debugging directly on the staging server, we figured out that an exception was being thrown by that SoapClient and it was being catched, but not logged:

javax.xml.rpc.soap.SOAPFaultException: IP_BLOCKED [] []

If we would have seen this in some log file, it would have been easier to figure out exactly why the vat number validation failed in our case.

Release note

Exceptions thrown by the VIES VAT validation service are now being logged in the var/log/exception.log file so it becomes easier to figure out what goes wrong when the validation doesn't work.

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @hostep. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

  :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant[bot]]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• [ ] 5. Add label Issue: Confirmed once verification is complete.

• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Verified the issue on Magento 2.4-develop instance and the issue is reproducible. Hence updating the description with Manual steps to reproduce and confirming the issue. No error/exception is being logged in the log files.

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-6906 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[hostep]

Thanks for confirming @engcom-November, note that there is already a PR open to fix this: https://github.com/magento/magento2/pull/36067

[ihor-sviziev]

The fix for this issue was delivered to 2.4-develop branch in https://github.com/magento/magento2/commit/50b303edae8c26ceb24fc23dcb42b1ed2feb1b76 (changes from https://github.com/magento/magento2/pull/36067) I'm closing this issue.