Meta Description Auto generation copying page builder tags

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.48k stars 9.29k forks source link

Meta Description Auto generation copying page builder tags #36107

Open vandijkstef opened 2 years ago

vandijkstef commented 2 years ago

Preconditions and environment

2.4.4
Page builder on the full description (product)

Steps to reproduce

Add a new product
Add some content in the full description field (pagebuilder enabled). (Edit with page builder - Add Content - Block - Drag and edit block - select block and save )
Review the meta description
Discover it is full of tags that should have no value

Expected result

Clean text-only output

Actual result

Schermafbeelding 2022-09-07 om 14 46 30

edit: This is the meta description field Schermafbeelding 2022-09-07 om 14 46 39

Additional information

The workaround is to manually update it, but chances are high it is forgotten to properly update it, thus having NOTHING would be preferred as Google is actually showing some of this garbage in it's results

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 2 years ago

Hi @vandijkstef. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

vandijkstef commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @vandijkstef. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @vandijkstef, here is your Magento Instance: https://2bc4eeb41888e69c2b930f938f4ebfc4.instances.magento-community.engineering Admin access: https://2bc4eeb41888e69c2b930f938f4ebfc4.instances.magento-community.engineering/admin_818e Login: bef9f7be Password: 1cb744b93df3

vandijkstef commented 2 years ago

Cannot verify currently as the page builder is not allowing me to drag-in any of the (layout) elements

vandijkstef commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @vandijkstef. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @vandijkstef, here is your Magento Instance: https://2bc4eeb41888e69c2b930f938f4ebfc4.instances.magento-community.engineering Admin access: https://2bc4eeb41888e69c2b930f938f4ebfc4.instances.magento-community.engineering/admin_5b9c Login: f6581b1f Password: 16eec39dcb7b

vandijkstef commented 2 years ago

Cannot verify currently as the page builder is not allowing me to drag-in any of the (layout) elements

Tried to verify again, above issue not resolved. Can't directly find an active issue on this.

m2-assistant[bot] commented 2 years ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-November commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-November. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-November, here is your Magento Instance: https://2bc4eeb41888e69c2b930f938f4ebfc4.instances.magento-community.engineering Admin access: https://2bc4eeb41888e69c2b930f938f4ebfc4.instances.magento-community.engineering/admin_afa8 Login: 27c95594 Password: 14cd64e8365f

engcom-November commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-November. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-November, here is your Magento Instance: https://2bc4eeb41888e69c2b930f938f4ebfc4.instances.magento-community.engineering Admin access: https://2bc4eeb41888e69c2b930f938f4ebfc4.instances.magento-community.engineering/admin_083f Login: 80c87964 Password: ee7b66625413

engcom-November commented 2 years ago

Hi @vandijkstef , Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop branch but unable to edit with Page builder for Products and this issue is being tracked in this bug: https://github.com/magento/magento2/issues/36188. This issue needs to be verified once above issue is resolved. Hence we are moving this issue to "On hold" Thank you.

chittima commented 1 year ago

Internal team is working on the fix

engcom-November commented 1 year ago

Verified the issue on Magento 2.4-develop instance with Page builder enabled in local instance and the issue is reproducible. Hence confirming the issue.

github-jira-sync-bot commented 1 year ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-7425 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 year ago

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

github-jira-sync-bot commented 1 year ago

:x: You don't have permission to export this issue.

vandijkstef commented 2 weeks ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 weeks ago

Hi @vandijkstef. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 weeks ago

Hi @vandijkstef, here is your Magento Instance: https://2bc4eeb41888e69c2b930f938f4ebfc4.instances-prod.magento-community.engineering Admin access: https://2bc4eeb41888e69c2b930f938f4ebfc4.instances-prod.magento-community.engineering/admin_b9e7 Login: 34e5993f Password: c53f981d794e

vandijkstef commented 2 weeks ago

The issue seems 'resolved'. On my own store I get PRODUCTTITLE - DESCRIPTION pattern in clean. On develop instance I see PRODUCTTITLE (so no description).

At least it's not producing garble anymore so this issue might be up for closing