Reorder product with options is failing

[florinm8]

Preconditions and environment

• Version: Magento 2.4.5
• php 8.1
• I use aheadworks/module-sarp2 module which adds subscription option, but i suspect it is not the cause of the issue. None of my orders - with products without subscription - have the option key on info_buyRequest (see detail on 'Actual result' section below)

Steps to reproduce

1. place an order with a product that add custom options
2. from 'My account' try to reorder.

Expected result

The product is added to cart and checkout can continue

Actual result

Exception occurs because \Magento\Sales\Model\Reorder\OrderInfoBuyRequestGetter::getInfoBuyRequest method assume that info_buyRequest have 'options' key

Commenting out the line if (array_key_exists($option['option_id'], $info['options'])) resolves the issue

Additional information

Below you can find the stack trace

`` TypeError: array_key_exists(): Argument #2 ($array) must be of type array, null given in /var/www/html/lund3/vendor/magento/module-sales/Model/Reorder/OrderInfoBuyRequestGetter.php:54 Stack trace:

0 /var/www/html/lund3/vendor/magento/module-sales/Model/Reorder/OrderInfoBuyRequestGetter.php(54): array_key_exists(0, NULL)

1 /var/www/html/lund3/vendor/magento/module-sales/Model/Reorder/Reorder.php(255): Magento\Sales\Model\Reorder\OrderInfoBuyRequestGetter->getInfoBuyRequest(Object(Magento\Sales\Model\Order\Item\Interceptor))

2 /var/www/html/lund3/vendor/magento/module-sales/Model/Reorder/Reorder.php(217): Magento\Sales\Model\Reorder\Reorder->addItemToCart(Object(Magento\Sales\Model\Order\Item\Interceptor), Object(Magento\Quote\Model\Quote\Interceptor), Object(Magento\Catalog\Model\Product\Interceptor))

``

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @florinm8. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

  :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• [ ] 5. Add label Issue: Confirmed once verification is complete.

• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-Bravo, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[engcom-Bravo]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-Bravo, here is your Magento Instance: https://60fb9d24d306c4b1da755ec5d1fccc28.instances.magento-community.engineering Admin access: https://60fb9d24d306c4b1da755ec5d1fccc28.instances.magento-community.engineering/admin_56b9 Login: 5d0d9974 Password: b1d322df0f38

[engcom-Bravo]

Hi @florinm8,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop branch and 2.4.5 but the issue is not reproducible. Created a Product with custom options and placed order successfully.Kindly refer the screenshots.

From my account we are able to Reorder the product with Custom options successfully.

Please let us know we miss anything.

Thanks.

[florinm8]

Hi, thanks for checking, it seems that the 3rd party aheadworks_sarp module is causing the issue. I got confused as the Magento\Sales\Model\Reorder\OrderInfoBuyRequestGetter class was introduced in magento 2.4.4 and it's working well without it.

[engcom-Bravo]

Hi @florinm8

Thanks for quick response.

Aheadworks/module-sarp2 module is a 3rd party extension and code of this extension is not part of https://github.com/magento/magento2 git repository. We are closing this issue as community is not able to provide fix for it in this repository. All questions, issue reports and fix for them should be addressed to the corresponding extension owners(support) on the Magento Market place page.

Thanks.