Empty block name error with module-price-permissions

nataliefox-288 commented 1 year ago

Preconditions and environment

Magento version: 2.4.5 There appears to be a bug in the enterprise module module-price-permissions when a block with no name is used (on an admin screen). A message is seen: Deprecated Functionality: stripos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /app/vendor/magento/module-price-permissions/Observer/AdminhtmlBlockHtmlBeforeObserver.php on line 125

Steps to reproduce

Using the Advanced Feeds module. Navigate to Catalog > Feeds

Expected result

Should be able to see list of feeds that have been set up.

Actual result

The error message is seen.

Additional information

No response

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[X] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 1 year ago

Hi @nataliefox-288. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 1 year ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-November commented 1 year ago

Hi @nataliefox-288 , Thank you for reporting and collaboration. However, Advanced Feeds module is a 3rd party extension and code of this extension is not part of https://github.com/magento/magento2 git repository. We are closing this issue as community is not able to provide fix for it in this repository. All questions, issue reports and fix for them should be addressed to the corresponding extension owners(support) on the Magento Market place page Thank you.

maxlussier commented 1 year ago

For those interested I have contacted Mirasvit Dev Team to inform them of the situation. They informed me that they will include the fix in their next release (1.2.9). In the meantime, here's the patch:

diff --git a/vendor/mirasvit/module-feed/src/Feed/Ui/Feed/Listing/DataProvider.php b/vendor/mirasvit/module-feed/src/Feed/Ui/Feed/Listing/DataProvider.php
--- a/vendor/mirasvit/module-feed/src/Feed/Ui/Feed/Listing/DataProvider.php
+++ b/vendor/mirasvit/module-feed/src/Feed/Ui/Feed/Listing/DataProvider.php
@@ -130,6 +130,7 @@
     {
         $statisticksBlock = $this->statisticksBlockFactory->create();
         $statisticksBlock->setData('feed', $item)
+            ->setNameInLayout('mst_feed_feed_statistics')
             ->setData('interval', $days);

         return $statisticksBlock->toHtml();

magento / magento2