magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.56k stars 9.32k forks source link

A non-numeric value encountered Error for Bundles with special price over 1000 #36284

Closed github-jira-sync-bot closed 2 years ago

github-jira-sync-bot commented 2 years ago

Steps to reproduce:

(x) Actual result:

An error occurs Non Numeric value encountered...

(/) Expected result:

Should be able to filter/see the bundled products with the special price

github-jira-sync-bot commented 2 years ago

The issue was exported from the internal Jira. The link to the original Jira issue: https://jira.corp.adobe.com/browse/ACP2E-1038

m2-assistant[bot] commented 2 years ago

Hi @github-jira-sync-bot. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

sunilit42 commented 1 year ago

Hello,

Any patch to solve it?

chittima commented 1 year ago

Hi @sunilit42 Please find the commit https://github.com/magento/magento2/commit/9456a2659f3466046e1d5c7eb45ae60bd4703934

LucScu commented 1 year ago

@chittima the commit not works correclty when admin account language is for example it_IT where the locale decimal symbol is comma. The value of percentage in the grid is different from the value setted in the price setting, because (float) '90,50' -> 90 instead of (float) '90.50' -> 90.5 It's just a display issue, in the product page is correctly calculated: special price is 90.50% of price.

chittima commented 1 year ago

Hi @LucScu Could you please create a new github issue with clear steps?