magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.51k stars 9.31k forks source link

/pub/errors/.htaccess is not Apache 2.4 compliant #36317

Closed gwharton closed 2 months ago

gwharton commented 2 years ago

Preconditions and environment

Steps to reproduce

https://github.com/magento/magento2/blob/49bd70677e2a65755b82ac81f5b561b01f14fce1/pub/errors/.htaccess#L2-L4

Expected result

Deny call is not valid in Apache 2.4

See other .htaccess files for reference. https://github.com/magento/magento2/blob/49bd70677e2a65755b82ac81f5b561b01f14fce1/pub/.htaccess#L207-L215

Actual result

Deny call is wrapped in Version calls to allow both Apache < 2.4 and Apache >= 2.4

Additional information

No response

Release note

No response

Triage and priority

m2-assistant[bot] commented 2 years ago

Hi @gwharton. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 2 years ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-November commented 2 years ago

Hi @gwharton , Thank you for reporting and collaboration. Verified the behavior on Magento 2.4-develop instance and is reproducible. I believe here no IfVersion checks are required as this is not version dependant configuration. In this case Deny call is still Apache 2.4 compliant. https://httpd.apache.org/docs/2.4/mod/mod_access_compat.html. Kindly recheck and confirm if we are missing anything to consider this as valid issue. Thank you.

gwharton commented 2 years ago

Right,

I see.

Given all other .htaccess files in Magento use the IfVersion call I would have thought that this one should too, to avoid having the dependency on the mod_access_compat module, which isn't listed as a requirement.

I'm not gonna die in a ditch over it, as I'll just enable the module, but there seems to have been an effort in the other .htaccess files to not require the compat module.

engcom-November commented 2 years ago

Thank you for the response @gwharton. We are confirming this issue as there is inconsistency among .htaccess files. Behavior should be same among all .htaccess files. mod_access_compat module is enabled by default in httpd.conf file and is not listed as a requirement and if no version check is made (Ex: pub/errors/.htaccess), .htaccess file require mod_access_compat.

github-jira-sync-bot commented 2 years ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-6855 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 years ago

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

pedromtalavera commented 1 year ago

Hi,

I created a PR for this #37707