Closed gwharton closed 2 months ago
Hi @gwharton. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:
Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
@magento give me 2.4-develop instance
- upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.
Join Magento Community Engineering Slack and ask your questions in #github channel.
:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
:clock10: You can find the schedule on the Magento Community Calendar page.
:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel
Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).Details
If the issue has a valid description, the label Issue: Format is valid
will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid
appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description
label to the issue by yourself.
[ ] 3. Add Component: XXXXX
label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop
branchDetails
- Add the comment @magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop
branch, please, add the label Reproduced on 2.4.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed
once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.
Hi @gwharton , Thank you for reporting and collaboration. Verified the behavior on Magento 2.4-develop instance and is reproducible. I believe here no IfVersion checks are required as this is not version dependant configuration. In this case Deny call is still Apache 2.4 compliant. https://httpd.apache.org/docs/2.4/mod/mod_access_compat.html. Kindly recheck and confirm if we are missing anything to consider this as valid issue. Thank you.
Right,
I see.
Given all other .htaccess files in Magento use the IfVersion call I would have thought that this one should too, to avoid having the dependency on the mod_access_compat module, which isn't listed as a requirement.
I'm not gonna die in a ditch over it, as I'll just enable the module, but there seems to have been an effort in the other .htaccess files to not require the compat module.
Thank you for the response @gwharton. We are confirming this issue as there is inconsistency among .htaccess files. Behavior should be same among all .htaccess files. mod_access_compat module is enabled by default in httpd.conf file and is not listed as a requirement and if no version check is made (Ex: pub/errors/.htaccess), .htaccess file require mod_access_compat.
:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-6855 is successfully created for this GitHub issue.
:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
Hi,
I created a PR for this #37707
Preconditions and environment
Steps to reproduce
https://github.com/magento/magento2/blob/49bd70677e2a65755b82ac81f5b561b01f14fce1/pub/errors/.htaccess#L2-L4
Expected result
Deny call is not valid in Apache 2.4
See other .htaccess files for reference. https://github.com/magento/magento2/blob/49bd70677e2a65755b82ac81f5b561b01f14fce1/pub/.htaccess#L207-L215
Actual result
Deny call is wrapped in Version calls to allow both Apache < 2.4 and Apache >= 2.4
Additional information
No response
Release note
No response
Triage and priority