magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.53k stars 9.31k forks source link

[UCT]Using class or Extending from class that is non API on version 2.4.5 #36380

Closed athreyag closed 1 year ago

athreyag commented 1 year ago

Preconditions and environment

I have generated Upgrade Compatibility Tool Report after upgrading from 2.4.2 to 2.4.5 and getting lots of errors in core files. Please find some of the errors reported for reference.

Extending from class 'Magento\Framework\App\Helper\AbstractHelper' that is non API on version '2.4.5' Extending from class 'Magento\ProductAlert\Model\Observer' that is non API on version '2.4.5' Using class 'Magento\Catalog\Model\ProductRepository' that is non API on version '2.4.5' Using class 'Magento\Framework\Model\ResourceModel\Db\Context' that is non API on version '2.4.5'

Steps to reproduce

  1. Upgrade to magento latest version.
  2. Install and run UCT tool to see the list of errors.

Expected result

UCT to list out critical issues, errors, and warnings in customized modules.

Actual result

Getting Errors in magento core files

Additional information

No response

Release note

No response

Triage and priority

m2-assistant[bot] commented 1 year ago

Hi @athreyag. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 1 year ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-November commented 1 year ago

Hi @athreyag , Thank you for reporting and collaboration. This issue related to Upgrade Compatibility tool should be reported here in this repository We are closing this issue. Kindly report here if you are facing any issues. Thank you.

sprajapat770 commented 2 months ago

@engcom-November you closed this issue do you have any solution for this problem. let me explain similar bug

i am creating custom ResourceModel class so i need to extend \Magento\Framework\Model\ResourceModel\Db\AbstractDb. i need to define 1 dependency in my constructor so i have to call \Magento\Framework\Model\ResourceModel\Db\Context in my constructor but in uct report i am getting error due to this class -> Using class 'Magento\Framework\Model\ResourceModel\Db\Context' that is non API on version '2.4.7-p1'

in magento core its implemented & no issue found -> vendor\magento\module-tax\Model\ResourceModel\Calculation.php

please resolve this issue.