magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.56k stars 9.32k forks source link

requirejs([''vimeo/player''], ...) doesn't work #36435

Closed 0m3r closed 2 years ago

0m3r commented 2 years ago

Preconditions and environment

Steps to reproduce

  1. open Magento 2.4.5 home page
  2. press F12 to open the dev toolbar
  3. run js code in a console
window.require(['jquery', 'vimeo/player', 'vimeo/vimeo-wrapper'], function (){console.log(arguments)});

jquery works vimeo/* doesn't work

because code here https://github.com/magento/magento2/blob/2b98dc6517c4148cb98afb25fa86efd63c348948/app/code/Magento/Theme/view/base/requirejs-config.js#L49

@anzin @andrewbess

Знімок екрана з 2022-11-08 15-48-45

Expected result

console without errors

Actual result

console with js errors

require.js:168 Uncaught Error: Script error for "vimeo/player/player"
require.js:168 Uncaught Error: Script error for "vimeo/player/vimeo-wrapper"

Знімок екрана з 2022-11-08 15-48-45

Additional information

I think the problem is here

https://github.com/magento/magento2/blob/2b98dc6517c4148cb98afb25fa86efd63c348948/app/code/Magento/Theme/view/base/requirejs-config.js#L49

https://github.com/magento/magento2/commit/2b98dc6517c4148cb98afb25fa86efd63c348948#diff-6bbf557f143626ce945375a3488dcdf7a55ecabf84cc53f4413197ffc3c5d3e7

Release note

No response

Triage and priority

m2-assistant[bot] commented 2 years ago

Hi @0m3r. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

0m3r commented 2 years ago

Sorry look like the problem is in Page Builder https://github.com/magento/magento2-page-builder/commit/a8b806386305712b6086bd4594aab817d5e34094

https://github.com/magento/magento2-page-builder/commit/a8b806386305712b6086bd4594aab817d5e34094#r80397027