[2.4.5-p1] Argument #1 ($fieldNode) must be of type GraphQL\\Language\\AST\\FieldNode, GraphQL\\Language\\AST\\InlineFragmentNode given

DuckThom commented 1 year ago

Preconditions and environment

Magento version: 2.4.5-p1
PHP 8.1

Steps to reproduce

Create a product with the url key 'a-product'
Create a category with the url key 'a-category'
Run the following GraphQL query:

fragment RouteFields on RoutableInterface {
    redirect_code
    relative_url
    type

    ... on ProductInterface {
        uid
        sku
        name
    }

    ... on CategoryInterface {
        uid
        name
    }
}

query Route {
    product: route(url: "a-product.html") {
        ...RouteFields
    }

    category: route(url: "a-category.html") {
        ...RouteFields
    }
}

Expected result

The routes for the product and category are returned

Actual result

A GraphQL error is returned along with the product data:

{
  "errors": [
    {
      "debugMessage": "Magento\\CatalogGraphQl\\Model\\AttributesJoiner::getQueryFields(): Argument #1 ($fieldNode) must be of type GraphQL\\Language\\AST\\FieldNode, GraphQL\\Language\\AST\\InlineFragmentNode given, called in \/Volumes\/Projects\/<redacted>\/magento\/htdocs\/vendor\/magento\/module-catalog-graph-ql\/Model\/AttributesJoiner.php on line 81",
      "message": "Internal server error",
      "extensions": {
        "category": "internal"
      },
      "locations": [
        {
          "line": 25,
          "column": 5
        }
      ],
      "path": [
        "category"
      ]
    }
  ],
  "data": {
    "product": {
      "redirect_code": 0,
      "relative_url": "a-product",
      "type": "PRODUCT",
      "uid": "NTg=",
      "sku": "533",
      "name": "A Product"
    },
    "category": null
  }
}

Additional information

Possible fix:

Replace the following line:

https://github.com/magento/magento2/blob/6dbb7fc48bd05eb2d00c9951b014aea9da7f73d7/app/code/Magento/CatalogGraphQl/Model/AttributesJoiner.php#L81

With this:

if ($spreadNode->kind === NodeKind::INLINE_FRAGMENT) {
    $fragmentFields[] = $this->addInlineFragmentFields($resolveInfo, $spreadNode);
} else {
    $fragmentFields[] = $this->getQueryFields($spreadNode, $resolveInfo);
}

I've marked it as S2 and S1 as it's critical when using GraphQL endpoints, but it's not critical when your shop doesn't make use of GraphQL.

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[X] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 1 year ago

Hi @DuckThom. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 1 year ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Bravo commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Bravo, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Bravo commented 1 year ago

Hi @DuckThom,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

1.Create a product with the url key 'a-product' 2.Create a category with the url key 'a-category' 3.Run the following GraphQL query:

Error in debug.log

Hence confirming this issue.

Thanks.

github-jira-sync-bot commented 1 year ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-7114 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 year ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

engcom-Hotel commented 1 year ago

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-7114 by the internal team Related commits: https://github.com/magento/magento2/search?q=AC-7114&type=commits

Based on the Jira ticket, the target version is 2.4.7-beta1.

Thanks

magento / magento2