Open adamlavery opened 1 year ago
Hi @adamlavery. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:
Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
@magento give me 2.4-develop instance
- upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.
Join Magento Community Engineering Slack and ask your questions in #github channel.
:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
:clock10: You can find the schedule on the Magento Community Calendar page.
:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel
As we can't do translations on a test instance, not requesting one!
Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
Issue: Format is valid
will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid
appears.Issue: Clear Description
label to the issue by yourself.Component: XXXXX
label(s) to the ticket, indicating the components it may be related to.2.4-develop
branch@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure. 2.4-develop
branch, please, add the label Reproduced on 2.4.x
.Issue resolved itself once a setup:upgrade was run for a different issue. Site is in developer mode so a cache:flush|clean should have been all that was needed to invoke this change. Perhaps you could investigate why whatever cache that held onto the old values was only flushed with a setup:upgrade instead of a cache:flush|clean.
Perhaps you could also consider implementing a cache:nuke command that properly clears all caches so next page load starts from the actual active codebase/database. It's quite ridiculous that we have to intermittently resort to manually deleting various files/folders to ensure we're actually using the code/config as specificied.
Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).Details
If the issue has a valid description, the label Issue: Format is valid
will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid
appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description
label to the issue by yourself.
[ ] 3. Add Component: XXXXX
label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop
branchDetails
- Add the comment @magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop
branch, please, add the label Reproduced on 2.4.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed
once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.
Hello @adamlavery,
Thanks for the reporting and collaboration!
We have tried to reproduce the issue in the latest 2.4-develop branch and the issue is reproducible for us. We have followed the below steps in order to reproduce the issue:
Add below translations in the files app/design/adminhtml/Magento/backend/i18n/en_US.csv
and app/design/frontend/Magento/luma/i18n/en_US.csv
:
"Please enter less or equal than %1 symbols.","Please enter maximum %1 characters."
"Please enter more or equal than %1 symbols.","Please enter minimum %1 characters."
"Please enter more or equal than {0} symbols.","Please enter maximum {0} characters."
"Please enter less or equal than {0} symbols.","Please enter minimum {0} characters."
"Edit item parameters","Edit item"
"Subscribe", "Start Saving"
Run the below commands to clear the cache:
bin/magento c:c
bin/magento c:f
Refresh the frontend and check the translations, this is translating well:
Check this path for other translations Admin Panel -> Marketing -> SEO & Search -> Site Map -> Add Sitemap
and try to add text greater than 32 characters in the Filename
field. New translations is not applied:
But after running bin/magento setup:upgrade
translations are working:
Hence confirming the issue.
Thanks
:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-7541 is successfully created for this GitHub issue.
:white_check_mark: Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
Preconditions and environment
OS 2.4.3-p1
Steps to reproduce
Trying to translate poorly worded form validation messages into proper English i.e.
Have created theme\il8n\en_GB.csv to include above corrections to proper English. Other "translations" in the csv file are applying correctly e.g.
Expected result
According to the following article, my theme translations should be being used: https://developer.adobe.com/commerce/frontend-core/guide/translations/dictionary/
How the application applies locales When the locale is changed for a store, the application searches and applies translations in the corresponding dictionaries in the following sequence:
Actual result
Re-deployed static content (in developer mode so shouldn't need to often do have to anyway) Cleared and flushed cache
Rule validation messages are not translated.
Additional information
Messages come from vendor\magento\module-ui\view\base\web\js\lib\validation\rules.js
Additional steps to reproduce the issue
Add below translations in the files
app/design/adminhtml/Magento/backend/i18n/en_US.csv
andapp/design/frontend/Magento/luma/i18n/en_US.csv
:Run the below commands to clear the cache:
Refresh the frontend and check the translations, this is translating well:
Check this path for other translations
Admin Panel -> Marketing -> SEO & Search -> Site Map -> Add Sitemap
and try to add text greater than 32 characters in theFilename
field. New translations is not applied:But after running
bin/magento setup:upgrade
translations are working:Release note
No response
Triage and priority