Closed arunmanglick-code closed 1 year ago
Hi @arunmanglick-code. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:
Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
@magento give me 2.4-develop instance
- upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.
Join Magento Community Engineering Slack and ask your questions in #github channel.
:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
:clock10: You can find the schedule on the Magento Community Calendar page.
:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel
Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).Details
If the issue has a valid description, the label Issue: Format is valid
will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid
appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description
label to the issue by yourself.
[ ] 3. Add Component: XXXXX
label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop
branchDetails
- Add the comment @magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop
branch, please, add the label Reproduced on 2.4.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed
once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.
@magento give me 2.4-develop instance
Hi @engcom-November. Thank you for your request. I'm working on Magento instance for you.
Hi @engcom-November, here is your Magento Instance: https://543bfc992d1dda68d9d51c67e43302c8.instances.magento-community.engineering Admin access: https://543bfc992d1dda68d9d51c67e43302c8.instances.magento-community.engineering/admin_44d7 Login: 47506ca3 Password: 05fa065e9c38
Hi @arunmanglick-code , Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop instance with below steps performed but the issue is not reproducible. Steps performed:
Kindly recheck the issue on Magento 2.4-develop instance and provide missing steps if any if the issue is still reproducible. Thank you.
Steps to reproduce error: 1) From Backend- Assign the Tax class to free-shipping such that when customer chose Colorado as a shipping country they will charge 0.27 on free-shipping order while placing a Taxable or Non Taxable Product. PFA Configuration.JPG
2)Front end - Placed an order with COD and free shipping 3)Admin - Created invoice for the order - No retail delivery fees is charged 4) Created credit memo for the order - You will get an error.
Example for the Original issue: Part 1: Recently CO Delivery Fee Implementation is taken care of across Magento connectors, where even if an Order/Invoice is with Zero/Free Shipping 0.27$ Retail Delivery Fee is charged. PFA request_tresponse.text request_response.txt
Part 2: Now if a seller tries to issue a Credit Memo (Refund) on the same Zero Shipping Order/Invoice, Magento blocks this. PFA Error.JPG
The error is because there is a check in vendor/magento/ module-sales/Model/Order/Creditmemo/Total/Discount.php file
@magento give me 2.4-develop instance
Hi @engcom-November. Thank you for your request. I'm working on Magento instance for you.
Hi @engcom-November, here is your Magento Instance: https://543bfc992d1dda68d9d51c67e43302c8.instances.magento-community.engineering Admin access: https://543bfc992d1dda68d9d51c67e43302c8.instances.magento-community.engineering/admin_2bc8 Login: 9fdd5686 Password: c4b9b7334ed1
@magento give me 2.4-develop instance
Hi @engcom-November. Thank you for your request. I'm working on Magento instance for you.
Hi @engcom-November, here is your Magento Instance: https://543bfc992d1dda68d9d51c67e43302c8.instances.magento-community.engineering Admin access: https://543bfc992d1dda68d9d51c67e43302c8.instances.magento-community.engineering/admin_8449 Login: c5012c76 Password: 765bbef207f8
Hi @divij-satra , Thank you for the response. Verified the issue again on Magento 2.4-develop instance with below steps but still unable to reproduce the issue.
HI @engcom-November Did you use the free shipping?
@engcom-November - Did you try this using Vertex Tax Calc Engine? If yes, can you please share the payloads, as this issue is very evident (attached in snapshots too in an earlier thread)?
Do you see an option where we can connect with you over the call and explain the problem statement and make best use of your time?
Thanks
@magento give me 2.4-develop instance
Hi @engcom-November. Thank you for your request. I'm working on Magento instance for you.
Hi @engcom-November, here is your Magento Instance: https://543bfc992d1dda68d9d51c67e43302c8.instances.magento-community.engineering Admin access: https://543bfc992d1dda68d9d51c67e43302c8.instances.magento-community.engineering/admin_9ccf Login: 8a4ceae9 Password: 4403420799c6
@magento give me 2.4-develop instance
Hi @engcom-November. Thank you for your request. I'm working on Magento instance for you.
Hi @engcom-November, here is your Magento Instance: https://543bfc992d1dda68d9d51c67e43302c8.instances.magento-community.engineering Admin access: https://543bfc992d1dda68d9d51c67e43302c8.instances.magento-community.engineering/admin_8ada Login: 6bd75c80 Password: 79cb5c5d7a90
Hi @arunmanglick-code , Thank you for the response. Vertex tax configuration is no more available in latest Magento versions. Code of this package / extension is not part of https://github.com/magento/magento2/ repository. If the issue occurring due to 3rd party extensions / packages enabled, all questions, issue reports and fix for them should be addressed to the corresponding extension owners(support) on the Magento Market place page. Kindly recheck the behavior on Magento 2.4-develop instance without 3rd party packages and please share your slack id so that we can connect with you over the call if the issue is still reproducible. Thank you.
Hi @arunmanglick-code , We are closing this issue as there has been no latest update on the same. Kindly reopen / create new issue if you are still facing any issues. Thank you.
Thanks Team, This issue cannot be closed with chats until you agree to be on call and see the demo. Thanks again
Summary
Part 1: Recently CO Delivery Fee Implementation is taken care of across Magento connectors, where even if an Order/Invoice is with Zero/Free Shipping 0.27$ Retail Delivery Fee is charged.
Part 2: Now if a seller tries to issue a Credit Memo (Refund) on the same Zero Shipping Order/Invoice, Magento blocks this functionality. (Note: O Series still applies a $0.27 Retail Delivery Fee, even if the Order is having Free Shipping)
Rationale, at the time of Invoice Creation with zero Shipping, O Series applies a $0.27 Retail Delivery Fee, and Magento stores this 0.27 Delivery Fee in Magento DB. Because of this, when a Credit Memo is issued against the zero-shipping order, Magento blocks the Request Payload from reaching Connector. (As Magento stored 0.27 in DB, it internally treats, it as Paid Shipping Order).
To make this feature work end to end, Adobe/Magento needs to do something to override this constraint. Looking forward to your assistance to take this forward with Adobe/Magento.
Thanks
Examples
To be attached
Proposed solution
No response
Release note
No response
Triage and priority