[Issue] Return shipping total including tax

m2-assistant[bot] commented 1 year ago

This issue is automatically created based on existing pull request: magento/magento2#35338: Return shipping total including tax

Description (*)

Return shipping total including tax for selected shipping method resolver. Vanilla Magento will always display the shipping price including tax within cart price summary, regardless of tax/calculation/shipping_includes_tax value. This logic is not mirrored in the graphql resolvers, however, as the base shipping amount is returned.

Vanilla Magento checkout with tax/calculation/shipping_includes_tax set to 1:

GraphQL cart query for shipping totals with tax/calculation/shipping_includes_tax set to 1:

query getCartDetails($cartId: String!) {
    cart(cart_id: $cartId) {
        shipping_addresses {
            selected_shipping_method {
                amount {
                    value
                    currency
                }
                carrier_code
                carrier_title
                method_code
                method_title
            }
        }
    }
}

{
  "data": {
    "cart": {
      "shipping_addresses": [
        {
          "selected_shipping_method": {
            "amount": {
              "value": 8.33,
              "currency": "GBP"
            },
            "carrier_code": "testshipping",
            "carrier_title": "Shipping",
            "method_code": "testshipping",
            "method_title": "Shipping"
          }
        }
      ]
    }
  }
}

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Setup latest version of M2.4
Set tax/calculation/shipping_includes_tax to 1 (or manually define shipping price to "Include Tax" via admin panel)
Configure standard tax class/rates of 20% for taxable goods
Create test product, assign to taxable goods tax class
Set "Flat Rate" shipping method "Enabled" field to "Yes" via admin panel
Set "Flat Rate" shipping method "Type" field to "Per Order" via admin panel
Set "Flat Rate" shipping method "Price" field to "10" via admin panel
Add test product to cart
Navigate to checkout, fill in shipping address data, select flat rate shipping method
Confirm order summary in checkout and cart lists shipping price as 10
Run example graphql query noted in ticket description on the same cart
Confirm that value returned is not the same as the value returned in checkout/cart summary

Questions or comments

Contribution checklist (*)

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[x] All new or changed code is covered with unit/integration tests (if applicable)
[x] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
[x] All automated tests passed successfully (all builds are green)

github-jira-sync-bot commented 1 year ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-7975 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 year ago

:white_check_mark: Confirmed by @engcom-Alfa. Thank you for verifying the issue.
Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

engcom-November commented 1 year ago

Hi all, Development team is currently working on this issue. Thank you.

engcom-Alfa commented 1 year ago

hey @liamjtoohey

kindly help us with more information on below PR raised by you. https://github.com/magento/magento2/pull/35338

Thanks

magento / magento2